web - add todo for potentially cyclic dependency

Benjamin Pasero · Benjamin Pasero · commit 7c53175eef11 · 2019-08-15T11:11:57.000+02:00
diff --git a/src/vs/workbench/browser/web.simpleservices.ts b/src/vs/workbench/browser/web.simpleservices.ts
@@ -412,6 +412,8 @@ export class SimpleWindowService extends Disposable implements IWindowService {
 	}
 
 	closeWindow(): Promise<void> {
+		window.close();
+
 		return Promise.resolve();
 	}
 
diff --git a/src/vs/workbench/contrib/debug/browser/extensionHostDebugService.ts b/src/vs/workbench/contrib/debug/browser/extensionHostDebugService.ts
@@ -17,7 +17,7 @@ class BrowserExtensionHostDebugService extends ExtensionHostDebugChannelClient {
 
 	constructor(
 		@IRemoteAgentService remoteAgentService: IRemoteAgentService,
-		//@IWindowService windowService: IWindowService,
+		// @IWindowService windowService: IWindowService, // TODO@weinand TODO@isidorn cyclic dependency?
 		@IEnvironmentService environmentService: IEnvironmentService
 	) {
 		const connection = remoteAgentService.getConnection();
@@ -30,13 +30,11 @@ class BrowserExtensionHostDebugService extends ExtensionHostDebugChannelClient {
 
 		this._register(this.onReload(event => {
 			if (environmentService.isExtensionDevelopment && environmentService.debugExtensionHost.debugId === event.sessionId) {
-				//windowService.reloadWindow();
 				window.location.reload();
 			}
 		}));
 		this._register(this.onClose(event => {
 			if (environmentService.isExtensionDevelopment && environmentService.debugExtensionHost.debugId === event.sessionId) {
-				//this._windowService.closeWindow();
 				window.close();
 			}
 		}));

Original file line number	Diff line number	Diff line change
`@@ -412,6 +412,8 @@ export class SimpleWindowService extends Disposable implements IWindowService {`
`412`	`412`	`}`
`413`	`413`
`414`	`414`	`closeWindow(): Promise<void> {`
	`415`	`+ window.close();`
	`416`	`+`
`415`	`417`	`return Promise.resolve();`
`416`	`418`	`}`
`417`	`419`