Skip to content

Commit 7bce874

Browse files
mjbvzmjbvz
committed
Mark fields private
1 parent c975752 commit 7bce874

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

‎src/vs/workbench/contrib/webview/browser/webviewEditor.ts‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ import { IEditorService } from 'vs/workbench/services/editor/common/editorServic
2424

2525
export class WebviewEditor extends BaseEditor {
2626

27-
protected _webview: Webview | undefined;
28-
protected findWidgetVisible: IContextKey<boolean>;
27+
private _webview: Webview | undefined;
28+
private _findWidgetVisible: IContextKey<boolean>;
2929

3030
public static readonly ID = 'WebviewEditor';
3131

@@ -39,7 +39,7 @@ export class WebviewEditor extends BaseEditor {
3939
private readonly _onDidFocusWebview = this._register(new Emitter<void>());
4040
public readonly onDidFocus: Event<any> = this._onDidFocusWebview.event;
4141

42-
private pendingMessages: any[] = [];
42+
private _pendingMessages: any[] = [];
4343

4444
constructor(
4545
@ITelemetryService telemetryService: ITelemetryService,
@@ -53,7 +53,7 @@ export class WebviewEditor extends BaseEditor {
5353
) {
5454
super(WebviewEditor.ID, telemetryService, themeService, storageService);
5555
if (_contextKeyService) {
56-
this.findWidgetVisible = KEYBINDING_CONTEXT_WEBVIEW_FIND_WIDGET_VISIBLE.bindTo(_contextKeyService);
56+
this._findWidgetVisible = KEYBINDING_CONTEXT_WEBVIEW_FIND_WIDGET_VISIBLE.bindTo(_contextKeyService);
5757
}
5858
}
5959

@@ -78,7 +78,7 @@ export class WebviewEditor extends BaseEditor {
7878
}
7979

8080
public dispose(): void {
81-
this.pendingMessages = [];
81+
this._pendingMessages = [];
8282

8383
// Let the editor input dispose of the webview.
8484
this._webview = undefined;
@@ -96,18 +96,18 @@ export class WebviewEditor extends BaseEditor {
9696
if (this._webview) {
9797
this._webview.sendMessage(data);
9898
} else {
99-
this.pendingMessages.push(data);
99+
this._pendingMessages.push(data);
100100
}
101101
}
102102
public showFind() {
103103
if (this._webview) {
104104
this._webview.showFind();
105-
this.findWidgetVisible.set(true);
105+
this._findWidgetVisible.set(true);
106106
}
107107
}
108108

109109
public hideFind() {
110-
this.findWidgetVisible.reset();
110+
this._findWidgetVisible.reset();
111111
if (this._webview) {
112112
this._webview.hideFind();
113113
}
@@ -178,7 +178,7 @@ export class WebviewEditor extends BaseEditor {
178178

179179
this._webview = undefined;
180180
this._webviewContent = undefined;
181-
this.pendingMessages = [];
181+
this._pendingMessages = [];
182182

183183
super.clearInput();
184184
}
@@ -189,7 +189,7 @@ export class WebviewEditor extends BaseEditor {
189189
this._webview = undefined;
190190
this._webviewContent = undefined;
191191
}
192-
this.pendingMessages = [];
192+
this._pendingMessages = [];
193193
return super.setInput(input, options, token)
194194
.then(() => input.resolve())
195195
.then(() => {
@@ -240,7 +240,7 @@ export class WebviewEditor extends BaseEditor {
240240
} else {
241241
if (input.options.enableFindWidget) {
242242
this._contextKeyService = this._register(this._contextKeyService.createScoped(this._webviewContent));
243-
this.findWidgetVisible = KEYBINDING_CONTEXT_WEBVIEW_FIND_WIDGET_VISIBLE.bindTo(this._contextKeyService);
243+
this._findWidgetVisible = KEYBINDING_CONTEXT_WEBVIEW_FIND_WIDGET_VISIBLE.bindTo(this._contextKeyService);
244244
}
245245

246246
this._webview = this._webviewService.createWebview(input.id,
@@ -263,10 +263,10 @@ export class WebviewEditor extends BaseEditor {
263263
this.doUpdateContainer();
264264
}
265265

266-
for (const message of this.pendingMessages) {
266+
for (const message of this._pendingMessages) {
267267
this._webview.sendMessage(message);
268268
}
269-
this.pendingMessages = [];
269+
this._pendingMessages = [];
270270

271271
this.trackFocus();
272272

0 commit comments

Comments
 (0)