storage - ensure to close DB on error

Benjamin Pasero · Benjamin Pasero · commit 7b7df809b6fa · 2018-11-21T17:10:22.000+01:00
diff --git a/src/vs/base/node/storage.ts b/src/vs/base/node/storage.ts
@@ -437,7 +437,7 @@ export class SQLiteStorageImpl {
 
 				const db = new (this.logger.isTracing ? sqlite3.verbose().Database : sqlite3.Database)(path, error => {
 					if (error) {
-						return reject(error);
+						return db.close(() => reject(error));
 					}
 
 					// The following exec() statement serves two purposes:
@@ -454,7 +454,7 @@ export class SQLiteStorageImpl {
 					}, error => {
 						mark('didSetupSQLiteSchema');
 
-						reject(error);
+						db.close(() => reject(error));
 					});
 				});
 
