Fix some strict null errors revealed by change to emitter

mjbvz · mjbvz · commit 7ae734397319 · 2020-04-08T18:06:24.000-07:00
diff --git a/extensions/npm/src/npmView.ts b/extensions/npm/src/npmView.ts
@@ -225,7 +225,7 @@ export class NpmScriptsTreeDataProvider implements TreeDataProvider<TreeItem> {
 
 	public refresh() {
 		this.taskTree = null;
-		this._onDidChangeTreeData.fire();
+		this._onDidChangeTreeData.fire(null);
 	}
 
 	getTreeItem(element: TreeItem): TreeItem {
diff --git a/extensions/typescript-language-features/src/typescriptServiceClient.ts b/extensions/typescript-language-features/src/typescriptServiceClient.ts
@@ -405,7 +405,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
 		handle.onEvent(event => this.dispatchEvent(event));
 
 		this._onReady!.resolve();
-		this._onTsServerStarted.fire(version.apiVersion);
+		this._onTsServerStarted.fire(apiVersion);
 
 		if (apiVersion.gte(API.v300)) {
 			this.loadingIndicator.startedLoadingProject(undefined /* projectName */);
diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
@@ -440,7 +440,7 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
 				const pty: Pseudoterminal = {
 					onDidWrite: writeEmitter.event,
 					onDidClose: closeEmitter.event,
-					open: () => closeEmitter.fire(),
+					open: () => closeEmitter.fire(undefined),
 					close: () => { }
 				};
 				const terminal = window.createTerminal({ name: 'foo', pty });

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ export class NpmScriptsTreeDataProvider implements TreeDataProvider<TreeItem> {`
`225`	`225`
`226`	`226`	`public refresh() {`
`227`	`227`	`this.taskTree = null;`
`228`		`- this._onDidChangeTreeData.fire();`
	`228`	`+ this._onDidChangeTreeData.fire(null);`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`getTreeItem(element: TreeItem): TreeItem {`