Only show error in tasks when exit code is non-zero

Tyriar · Tyriar · commit 7ad78e6573a6 · 2020-06-12T11:23:56.000-07:00
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
@@ -966,7 +966,11 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 		// Create exit code message
 		switch (typeof exitCodeOrError) {
 			case 'number':
+				// Only show the error if the exit code is non-zero
 				this._exitCode = exitCodeOrError;
+				if (this._exitCode === 0) {
+					break;
+				}
 
 				let commandLine: string | undefined = undefined;
 				if (this._shellLaunchConfig.executable) {
diff --git a/src/vs/workbench/contrib/terminal/node/terminalProcess.ts b/src/vs/workbench/contrib/terminal/node/terminalProcess.ts
@@ -78,7 +78,7 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
 		const results = await Promise.all([this._validateCwd(), this._validateExecutable()]);
 		const firstError = results.find(r => r !== undefined);
 		if (firstError) {
-			// TODO: Anything else we need to do here?
+			// TODO: Anything else we need to do here to tear down the terminal instance?
 			// this._processStartupComplete = Promise.resolve(undefined);
 			// this._onProcessExit.fire(0);
 
@@ -89,10 +89,7 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
 			this.setupPtyProcess(this._shellLaunchConfig, this._ptyOptions);
 			return undefined;
 		} catch (err) {
-
-			// TODO: Anything else we need to do here?
-
-			// TODO: Extract code and message from the native exception, currently they're combined
+			// TODO: Anything else we need to do here to tear down the terminal instance?
 			// A native exception occurred
 			this._logService.trace('IPty#spawn native exception', err);
 			return { message: `A native exception occurred during launch (${err.message})` };
