show 0 of n instead of hiding badge

Pascal Fong Kye · Pascal Fong Kye · commit 79909fd208ff · 2020-09-22T14:58:17.000+02:00
diff --git a/src/vs/workbench/contrib/debug/browser/replFilter.ts b/src/vs/workbench/contrib/debug/browser/replFilter.ts
@@ -223,7 +223,7 @@ export class ReplFilterActionViewItem extends BaseActionViewItem {
 	private updateBadge(): void {
 		if (this.filterBadge) {
 			const { total, filtered } = this.filters.filterStats;
-			const filterBadgeHidden = total === filtered || filtered === 0;
+			const filterBadgeHidden = total === filtered || total === 0;
 
 			this.filterBadge.classList.toggle('hidden', filterBadgeHidden);
 			this.filterBadge.textContent = localize('showing filtered repl lines', "Showing {0} of {1}", filtered, total);
diff --git a/src/vs/workbench/contrib/markers/browser/markersViewActions.ts b/src/vs/workbench/contrib/markers/browser/markersViewActions.ts
@@ -392,7 +392,7 @@ export class MarkersFilterActionViewItem extends BaseActionViewItem {
 	private updateBadge(): void {
 		if (this.filterBadge) {
 			const { total, filtered } = this.filterController.getFilterStats();
-			this.filterBadge.classList.toggle('hidden', total === filtered || filtered === 0);
+			this.filterBadge.classList.toggle('hidden', total === filtered || total === 0);
 			this.filterBadge.textContent = localize('showing filtered problems', "Showing {0} of {1}", filtered, total);
 			this.adjustInputBox();
 		}

Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,7 @@ export class MarkersFilterActionViewItem extends BaseActionViewItem {`
`392`	`392`	`private updateBadge(): void {`
`393`	`393`	`if (this.filterBadge) {`
`394`	`394`	`const { total, filtered } = this.filterController.getFilterStats();`
`395`		`- this.filterBadge.classList.toggle('hidden', total === filtered \|\| filtered === 0);`
	`395`	`+ this.filterBadge.classList.toggle('hidden', total === filtered \|\| total === 0);`
`396`	`396`	`this.filterBadge.textContent = localize('showing filtered problems', "Showing {0} of {1}", filtered, total);`
`397`	`397`	`this.adjustInputBox();`
`398`	`398`	`}`