stdin - ignore if a file path is passed in to open

Benjamin Pasero · Benjamin Pasero · commit 785a04468afa · 2017-11-28T07:38:56.000+01:00
diff --git a/src/vs/code/node/cli.ts b/src/vs/code/node/cli.ts
@@ -67,10 +67,11 @@ export async function main(argv: string[]): TPromise<any> {
 		}
 
 		// If we are running with input from stdin, pipe that into a file and
-		// open this file via arguments.
+		// open this file via arguments. Ignore this when we are passed with
+		// paths to open. 
 		let isReadingFromStdin: boolean;
 		try {
-			isReadingFromStdin = !process.stdin.isTTY; // Via https://twitter.com/MylesBorins/status/782009479382626304
+			isReadingFromStdin = args._.length === 0 && !process.stdin.isTTY; // Via https://twitter.com/MylesBorins/status/782009479382626304
 		} catch (error) {
 			// Windows workaround for https://github.com/nodejs/node/issues/11656
 		}

Original file line number	Diff line number	Diff line change
`@@ -67,10 +67,11 @@ export async function main(argv: string[]): TPromise<any> {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`// If we are running with input from stdin, pipe that into a file and`
`70`		`- // open this file via arguments.`
	`70`	`+ // open this file via arguments. Ignore this when we are passed with`
	`71`	`+ // paths to open.`
`71`	`72`	`let isReadingFromStdin: boolean;`
`72`	`73`	`try {`
`73`		`- isReadingFromStdin = !process.stdin.isTTY; // Via https://twitter.com/MylesBorins/status/782009479382626304`
	`74`	`+ isReadingFromStdin = args._.length === 0 && !process.stdin.isTTY; // Via https://twitter.com/MylesBorins/status/782009479382626304`
`74`	`75`	`} catch (error) {`
`75`	`76`	`// Windows workaround for https://github.com/nodejs/node/issues/11656`
`76`	`77`	`}`