Skip to content

Commit 76e45c2

Browse files
committed
debug: make serverReadyAction play nicely with js-debug
Fixes microsoft#86035 Fixes microsoft/vscode-js-debug#440
1 parent 62f1bf8 commit 76e45c2

1 file changed

Lines changed: 7 additions & 12 deletions

File tree

‎extensions/debug-server-ready/src/extension.ts‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -146,18 +146,13 @@ class ServerReadyDetector extends vscode.Disposable {
146146
break;
147147

148148
case 'debugWithChrome':
149-
if (vscode.env.remoteName === 'wsl' || !!vscode.extensions.getExtension('msjsdiag.debugger-for-chrome')) {
150-
vscode.debug.startDebugging(session.workspaceFolder, {
151-
type: 'chrome',
152-
name: 'Chrome Debug',
153-
request: 'launch',
154-
url: uri,
155-
webRoot: args.webRoot || WEB_ROOT
156-
}, session);
157-
} else {
158-
const errMsg = localize('server.ready.chrome.not.installed', "The action '{0}' requires the '{1}' extension.", 'debugWithChrome', 'Debugger for Chrome');
159-
vscode.window.showErrorMessage(errMsg, { modal: true }).then(_ => undefined);
160-
}
149+
vscode.debug.startDebugging(session.workspaceFolder, {
150+
type: 'pwa-chrome',
151+
name: 'Chrome Debug',
152+
request: 'launch',
153+
url: uri,
154+
webRoot: args.webRoot || WEB_ROOT
155+
});
161156
break;
162157

163158
default:

0 commit comments

Comments
 (0)