Skip to content

Commit 760df93

Browse files
author
Benjamin Pasero
committed
build - document loading approach better
1 parent 40e7935 commit 760df93

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/vs/code/electron-browser/workbench/workbench.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ const bootstrapWindow = require('../../../../bootstrap-window');
1414
// Setup shell environment
1515
process['lazyEnv'] = getLazyEnv();
1616

17-
// Load workbench main
17+
// Load workbench main JS, CSS and NLS all in parallel. This is an
18+
// optimization to prevent a waterfall of loading to happen, because
19+
// we know for a fact that workbench.desktop.main will depend on
20+
// the related CSS and NLS counterparts.
1821
bootstrapWindow.load([
1922
'vs/workbench/workbench.desktop.main',
2023
'vs/nls!vs/workbench/workbench.desktop.main',

src/vs/workbench/workbench.web.api.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import 'vs/workbench/workbench.web.main';
7-
import 'vs/nls!vs/workbench/workbench.web.main';
8-
import 'vs/css!vs/workbench/workbench.web.main';
97
import { main } from 'vs/workbench/browser/web.main';
108
import { UriComponents } from 'vs/base/common/uri';
119
import { IFileSystemProvider } from 'vs/platform/files/common/files';

0 commit comments

Comments
 (0)