Skip to content

Commit 75d5bc4

Browse files
joaomorenojoaomoreno
committed
rename IDataSource
1 parent 588184d commit 75d5bc4

12 files changed

Lines changed: 23 additions & 23 deletions

File tree

‎src/vs/base/browser/ui/tree/asyncDataTree.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { ComposedTreeDelegate, IAbstractTreeOptions } from 'vs/base/browser/ui/tree/abstractTree';
77
import { ObjectTree, IObjectTreeOptions } from 'vs/base/browser/ui/tree/objectTree';
88
import { IListVirtualDelegate, IIdentityProvider } from 'vs/base/browser/ui/list/list';
9-
import { ITreeElement, ITreeNode, ITreeRenderer, ITreeEvent, ITreeMouseEvent, ITreeContextMenuEvent, ITreeSorter, ICollapseStateChangeEvent, IDataSource } from 'vs/base/browser/ui/tree/tree';
9+
import { ITreeElement, ITreeNode, ITreeRenderer, ITreeEvent, ITreeMouseEvent, ITreeContextMenuEvent, ITreeSorter, ICollapseStateChangeEvent, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
1010
import { IDisposable, dispose } from 'vs/base/common/lifecycle';
1111
import { Emitter, Event } from 'vs/base/common/event';
1212
import { timeout, always } from 'vs/base/common/async';
@@ -204,7 +204,7 @@ export class AsyncDataTree<T extends NonNullable<any>, TFilterData = void> imple
204204
container: HTMLElement,
205205
delegate: IListVirtualDelegate<T>,
206206
renderers: ITreeRenderer<any /* TODO@joao */, TFilterData, any>[],
207-
private dataSource: IDataSource<T>,
207+
private dataSource: IAsyncDataSource<T>,
208208
options?: IAsyncDataTreeOptions<T, TFilterData>
209209
) {
210210
this.identityProvider = options && options.identityProvider;

‎src/vs/base/browser/ui/tree/tree.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export interface ITreeNavigator<T> {
145145
next(): T | null;
146146
}
147147

148-
export interface IDataSource<T extends NonNullable<any>> {
148+
export interface IAsyncDataSource<T extends NonNullable<any>> {
149149
hasChildren(element: T | null): boolean;
150150
getChildren(element: T | null): Promise<T[]>;
151151
}

‎src/vs/base/test/browser/ui/tree/asyncDataTree.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import * as assert from 'assert';
7-
import { ITreeNode, ITreeRenderer, IDataSource } from 'vs/base/browser/ui/tree/tree';
7+
import { ITreeNode, ITreeRenderer, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
88
import { AsyncDataTree } from 'vs/base/browser/ui/tree/asyncDataTree';
99
import { IListVirtualDelegate, IIdentityProvider } from 'vs/base/browser/ui/list/list';
1010
import { hasClass } from 'vs/base/browser/dom';
@@ -51,7 +51,7 @@ suite('AsyncDataTree', function () {
5151
}
5252
};
5353

54-
const dataSource = new class implements IDataSource<Element> {
54+
const dataSource = new class implements IAsyncDataSource<Element> {
5555
hasChildren(element: Element | null): boolean {
5656
return !element || (element.children && element.children.length > 0);
5757
}

‎src/vs/editor/contrib/referenceSearch/referencesTree.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import { ReferencesModel, FileReferences, OneReference } from './referencesModel';
88
import { ITextModelService } from 'vs/editor/common/services/resolverService';
9-
import { ITreeRenderer, ITreeNode, IDataSource } from 'vs/base/browser/ui/tree/tree';
9+
import { ITreeRenderer, ITreeNode, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
1010
import { IconLabel } from 'vs/base/browser/ui/iconLabel/iconLabel';
1111
import { CountBadge } from 'vs/base/browser/ui/countBadge/countBadge';
1212
import { ILabelService } from 'vs/platform/label/common/label';
@@ -26,7 +26,7 @@ import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
2626

2727
export type TreeElement = FileReferences | OneReference;
2828

29-
export class DataSource implements IDataSource<TreeElement> {
29+
export class DataSource implements IAsyncDataSource<TreeElement> {
3030

3131
root: ReferencesModel | FileReferences;
3232

‎src/vs/editor/contrib/referenceSearch/referencesWidget.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import { activeContrastBorder, contrastBorder, registerColor } from 'vs/platform
3131
import { ITheme, IThemeService, registerThemingParticipant } from 'vs/platform/theme/common/themeService';
3232
import { PeekViewWidget } from './peekViewWidget';
3333
import { FileReferences, OneReference, ReferencesModel } from './referencesModel';
34-
import { ITreeRenderer, IDataSource } from 'vs/base/browser/ui/tree/tree';
34+
import { ITreeRenderer, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
3535
import { IAsyncDataTreeOptions } from 'vs/base/browser/ui/tree/asyncDataTree';
3636
import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
3737

@@ -359,7 +359,7 @@ export class ReferenceWidget extends PeekViewWidget {
359359

360360
this._treeDataSource = this._instantiationService.createInstance(DataSource);
361361

362-
this._tree = this._instantiationService.createInstance<HTMLElement, IListVirtualDelegate<TreeElement>, ITreeRenderer<any, void, any>[], IDataSource<TreeElement>, IAsyncDataTreeOptions<TreeElement, void>, WorkbenchAsyncDataTree<TreeElement, void>>(
362+
this._tree = this._instantiationService.createInstance<HTMLElement, IListVirtualDelegate<TreeElement>, ITreeRenderer<any, void, any>[], IAsyncDataSource<TreeElement>, IAsyncDataTreeOptions<TreeElement, void>, WorkbenchAsyncDataTree<TreeElement, void>>(
363363
WorkbenchAsyncDataTree,
364364
this._treeContainer,
365365
new Delegate(),

‎src/vs/platform/list/browser/listService.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import { attachInputBoxStyler, attachListStyler, computeStyles, defaultListStyle
3232
import { IThemeService } from 'vs/platform/theme/common/themeService';
3333
import { InputFocusedContextKey } from 'vs/platform/workbench/common/contextkeys';
3434
import { ObjectTree, IObjectTreeOptions } from 'vs/base/browser/ui/tree/objectTree';
35-
import { ITreeEvent, ITreeRenderer, IDataSource } from 'vs/base/browser/ui/tree/tree';
35+
import { ITreeEvent, ITreeRenderer, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
3636
import { AsyncDataTree, IAsyncDataTreeOptions } from 'vs/base/browser/ui/tree/asyncDataTree';
3737

3838
export type ListWidget = List<any> | PagedList<any> | ITree | ObjectTree<any, any> | AsyncDataTree<any, any>;
@@ -969,7 +969,7 @@ export class WorkbenchAsyncDataTree<T extends NonNullable<any>, TFilterData = vo
969969
container: HTMLElement,
970970
delegate: IListVirtualDelegate<T>,
971971
renderers: ITreeRenderer<any /* TODO@joao */, TFilterData, any>[],
972-
dataSource: IDataSource<T>,
972+
dataSource: IAsyncDataSource<T>,
973973
options: IAsyncDataTreeOptions<T, TFilterData>,
974974
@IContextKeyService contextKeyService: IContextKeyService,
975975
@IListService listService: IListService,

‎src/vs/workbench/parts/debug/browser/loadedScriptsView.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { RunOnceScheduler } from 'vs/base/common/async';
2626
import { ResourceLabel, IResourceLabel, IResourceLabelOptions } from 'vs/workbench/browser/labels';
2727
import { FileKind } from 'vs/platform/files/common/files';
2828
import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
29-
import { ITreeRenderer, ITreeNode, ITreeFilter, TreeVisibility, TreeFilterResult, IDataSource } from 'vs/base/browser/ui/tree/tree';
29+
import { ITreeRenderer, ITreeNode, ITreeFilter, TreeVisibility, TreeFilterResult, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
3030
import { IAccessibilityProvider } from 'vs/base/browser/ui/list/listWidget';
3131
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
3232
import { WorkbenchAsyncDataTree, IListService, TreeResourceNavigator2 } from 'vs/platform/list/browser/listService';
@@ -535,7 +535,7 @@ class LoadedScriptsDelegate implements IListVirtualDelegate<LoadedScriptsItem> {
535535
}
536536
}
537537

538-
class LoadedScriptsDataSource implements IDataSource<LoadedScriptsItem> {
538+
class LoadedScriptsDataSource implements IAsyncDataSource<LoadedScriptsItem> {
539539

540540
constructor(private root: LoadedScriptsItem) {
541541
}

‎src/vs/workbench/parts/debug/electron-browser/callStackView.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { DebugSession } from 'vs/workbench/parts/debug/electron-browser/debugSes
2727
import { IAccessibilityProvider } from 'vs/base/browser/ui/list/listWidget';
2828
import { fillInContextMenuActions } from 'vs/platform/actions/browser/menuItemActionItem';
2929
import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
30-
import { ITreeRenderer, ITreeNode, ITreeContextMenuEvent, IDataSource } from 'vs/base/browser/ui/tree/tree';
30+
import { ITreeRenderer, ITreeNode, ITreeContextMenuEvent, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
3131
import { TreeResourceNavigator2, WorkbenchAsyncDataTree, IListService } from 'vs/platform/list/browser/listService';
3232
import { IThemeService } from 'vs/platform/theme/common/themeService';
3333

@@ -571,7 +571,7 @@ class CallStackDelegate implements IListVirtualDelegate<CallStackItem> {
571571
}
572572
}
573573

574-
class CallStackDataSource implements IDataSource<CallStackItem> {
574+
class CallStackDataSource implements IAsyncDataSource<CallStackItem> {
575575
deemphasizedStackFramesToShow: IStackFrame[];
576576

577577
constructor(private debugService: IDebugService) { }

‎src/vs/workbench/parts/debug/electron-browser/debugHover.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import { IConfigurationService } from 'vs/platform/configuration/common/configur
3232
import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
3333
import { coalesce } from 'vs/base/common/arrays';
3434
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
35-
import { IDataSource } from 'vs/base/browser/ui/tree/tree';
35+
import { IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
3636

3737
const $ = dom.$;
3838
const MAX_TREE_HEIGHT = 324;
@@ -291,7 +291,7 @@ class DebugHoverAccessibilityProvider implements IAccessibilityProvider<IExpress
291291
}
292292
}
293293

294-
class DebugHoverDataSource implements IDataSource<IExpression> {
294+
class DebugHoverDataSource implements IAsyncDataSource<IExpression> {
295295

296296
expression: IExpression;
297297

‎src/vs/workbench/parts/debug/electron-browser/repl.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ import { IAccessibilityProvider } from 'vs/base/browser/ui/list/listWidget';
5151
import { Variable, Expression, SimpleReplElement, RawObjectReplElement } from 'vs/workbench/parts/debug/common/debugModel';
5252
import { IListVirtualDelegate } from 'vs/base/browser/ui/list/list';
5353
import { VariablesRenderer } from 'vs/workbench/parts/debug/electron-browser/variablesView';
54-
import { ITreeRenderer, ITreeNode, ITreeContextMenuEvent, IDataSource } from 'vs/base/browser/ui/tree/tree';
54+
import { ITreeRenderer, ITreeNode, ITreeContextMenuEvent, IAsyncDataSource } from 'vs/base/browser/ui/tree/tree';
5555
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
5656
import { renderExpressionValue } from 'vs/workbench/parts/debug/browser/baseDebugView';
5757
import { handleANSIOutput } from 'vs/workbench/parts/debug/browser/debugANSIHandling';
@@ -751,7 +751,7 @@ class ReplDelegate implements IListVirtualDelegate<IReplElement> {
751751
}
752752

753753

754-
class ReplDataSource implements IDataSource<IReplElement> {
754+
class ReplDataSource implements IAsyncDataSource<IReplElement> {
755755
input: IDebugSession;
756756

757757
hasChildren(element: IReplElement | null): boolean {

0 commit comments

Comments
 (0)