Check for updates only once at launch (microsoft#72169)

ahinkle · joaomoreno · commit 753732c8ed2d · 2019-08-08T12:23:38.000+02:00
* Check for updates only once at launch

* Update Mode Fix

* Add Start to enum config

* Check For Updates on Startup
diff --git a/src/vs/platform/update/electron-main/abstractUpdateService.ts b/src/vs/platform/update/electron-main/abstractUpdateService.ts
@@ -81,8 +81,13 @@ export abstract class AbstractUpdateService implements IUpdateService {
 			return;
 		}
 
-		// Start checking for updates after 30 seconds
-		this.scheduleCheckForUpdates(30 * 1000).then(undefined, err => this.logService.error(err));
+		if (updateMode === 'start') {
+			this.logService.info('update#ctor - startup checks only; automatic updates are disabled by user preference');
+			this.checkForUpdates(null);
+		} else {
+			// Create schedule after checking for updates in 30 seconds
+			this.scheduleCheckForUpdates(30 * 1000).then(undefined, err => this.logService.error(err));
+		}
 	}
 
 	private getProductQuality(updateMode: string): string | undefined {
diff --git a/src/vs/platform/update/node/update.config.contribution.ts b/src/vs/platform/update/node/update.config.contribution.ts
@@ -17,14 +17,15 @@ configurationRegistry.registerConfiguration({
 	properties: {
 		'update.mode': {
 			type: 'string',
-			enum: ['none', 'manual', 'default'],
+			enum: ['none', 'manual', 'start', 'default'],
 			default: 'default',
 			scope: ConfigurationScope.APPLICATION,
 			description: localize('updateMode', "Configure whether you receive automatic updates. Requires a restart after change. The updates are fetched from a Microsoft online service."),
 			tags: ['usesOnlineServices'],
 			enumDescriptions: [
 				localize('none', "Disable updates."),
 				localize('manual', "Disable automatic background update checks. Updates will be available if you manually check for updates."),
+				localize('start', "Code will check for updates on launch. Disable automatic background update checks. "),
 				localize('default', "Enable automatic update checks. Code will check for updates automatically and periodically.")
 			]
 		},

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,13 @@ export abstract class AbstractUpdateService implements IUpdateService {`
`81`	`81`	`return;`
`82`	`82`	`}`
`83`	`83`
`84`		`- // Start checking for updates after 30 seconds`
`85`		`- this.scheduleCheckForUpdates(30 * 1000).then(undefined, err => this.logService.error(err));`
	`84`	`+ if (updateMode === 'start') {`
	`85`	`+ this.logService.info('update#ctor - startup checks only; automatic updates are disabled by user preference');`
	`86`	`+ this.checkForUpdates(null);`
	`87`	`+ } else {`
	`88`	`+ // Create schedule after checking for updates in 30 seconds`
	`89`	`+ this.scheduleCheckForUpdates(30 * 1000).then(undefined, err => this.logService.error(err));`
	`90`	`+ }`
`86`	`91`	`}`
`87`	`92`
`88`	`93`	`private getProductQuality(updateMode: string): string \| undefined {`