debt - remove unused strings#overlap

jrieken · jrieken · commit 74b9e5bfda20 · 2020-03-05T10:09:03.000+01:00
diff --git a/src/vs/base/common/strings.ts b/src/vs/base/common/strings.ts
@@ -428,43 +428,6 @@ export function commonSuffixLength(a: string, b: string): number {
 	return len;
 }
 
-function substrEquals(a: string, aStart: number, aEnd: number, b: string, bStart: number, bEnd: number): boolean {
-	while (aStart < aEnd && bStart < bEnd) {
-		if (a[aStart] !== b[bStart]) {
-			return false;
-		}
-		aStart += 1;
-		bStart += 1;
-	}
-	return true;
-}
-
-/**
- * Return the overlap between the suffix of `a` and the prefix of `b`.
- * For instance `overlap("foobar", "arr, I'm a pirate") === 2`.
- */
-export function overlap(a: string, b: string): number {
-	const aEnd = a.length;
-	let bEnd = b.length;
-	let aStart = aEnd - bEnd;
-
-	if (aStart === 0) {
-		return a === b ? aEnd : 0;
-	} else if (aStart < 0) {
-		bEnd += aStart;
-		aStart = 0;
-	}
-
-	while (aStart < aEnd && bEnd > 0) {
-		if (substrEquals(a, aStart, aEnd, b, 0, bEnd)) {
-			return bEnd;
-		}
-		bEnd -= 1;
-		aStart += 1;
-	}
-	return 0;
-}
-
 // --- unicode
 // http://en.wikipedia.org/wiki/Surrogate_pair
 // Returns the code point starting at a specified index in a string
diff --git a/src/vs/base/test/common/strings.test.ts b/src/vs/base/test/common/strings.test.ts
@@ -92,15 +92,6 @@ suite('Strings', () => {
 		assert.strictEqual(strings.format('Foo {0} Bar. {1}', '(foo)', '.test'), 'Foo (foo) Bar. .test');
 	});
 
-	test('overlap', () => {
-		assert.equal(strings.overlap('foobar', 'arr, I am a priate'), 2);
-		assert.equal(strings.overlap('no', 'overlap'), 1);
-		assert.equal(strings.overlap('no', '0verlap'), 0);
-		assert.equal(strings.overlap('nothing', ''), 0);
-		assert.equal(strings.overlap('', 'nothing'), 0);
-		assert.equal(strings.overlap('full', 'full'), 4);
-		assert.equal(strings.overlap('full', 'fulloverlap'), 4);
-	});
 	test('lcut', () => {
 		assert.strictEqual(strings.lcut('foo bar', 0), '');
 		assert.strictEqual(strings.lcut('foo bar', 1), 'bar');
