@@ -55,12 +55,15 @@ export class CompletionItem {
5555 idx ?: number ;
5656 word ?: string ;
5757
58+ // resolving
59+ private _isResolved : boolean = false ;
60+ private _resolveCache ?: Promise < void > ;
61+
5862 constructor (
5963 readonly position : IPosition ,
6064 readonly completion : modes . CompletionItem ,
6165 readonly container : modes . CompletionList ,
6266 readonly provider : modes . CompletionItemProvider ,
63- model : ITextModel
6467 ) {
6568 this . textLabel = typeof completion . label === 'string'
6669 ? completion . label
@@ -104,14 +107,12 @@ export class CompletionItem {
104107 }
105108 }
106109
107- // resolving
110+ // ---- resolving
111+
108112 get isResolved ( ) {
109- return Boolean ( this . _isResolved ) ;
113+ return this . _isResolved ;
110114 }
111115
112- private _resolveCache ?: Promise < void > ;
113- private _isResolved ?: boolean ;
114-
115116 async resolve ( token : CancellationToken ) {
116117 if ( ! this . _resolveCache ) {
117118 const sub = token . onCancellationRequested ( ( ) => {
@@ -194,7 +195,7 @@ export async function provideSuggestionItems(
194195 if ( ! suggestion . sortText ) {
195196 suggestion . sortText = typeof suggestion . label === 'string' ? suggestion . label : suggestion . label . name ;
196197 }
197- result . push ( new CompletionItem ( position , suggestion , container , provider , model ) ) ;
198+ result . push ( new CompletionItem ( position , suggestion , container , provider ) ) ;
198199 }
199200 }
200201 if ( isDisposable ( container ) ) {
0 commit comments