debt - change delete operand (for microsoft#96022)

Benjamin Pasero · Benjamin Pasero · commit 720b72ea268e · 2020-04-24T07:20:54.000+02:00
diff --git a/src/vs/code/electron-main/window.ts b/src/vs/code/electron-main/window.ts
@@ -746,11 +746,11 @@ export class CodeWindow extends Disposable implements ICodeWindow {
 
 		// Config (combination of process.argv and window configuration)
 		const environment = parseArgs(process.argv, OPTIONS);
-		const config = Object.assign(environment, windowConfiguration);
+		const config = Object.assign(environment, windowConfiguration) as unknown as { [key: string]: unknown };
 		for (const key in config) {
-			const configValue = (config as any)[key];
+			const configValue = config[key];
 			if (configValue === undefined || configValue === null || configValue === '' || configValue === false) {
-				delete (config as any)[key]; // only send over properties that have a true value
+				delete config[key]; // only send over properties that have a true value
 			}
 		}
 
diff --git a/src/vs/workbench/browser/parts/statusbar/statusbarPart.ts b/src/vs/workbench/browser/parts/statusbar/statusbarPart.ts
@@ -703,7 +703,7 @@ class StatusbarEntryItem extends Disposable {
 			if (entry.tooltip) {
 				this.container.title = entry.tooltip;
 			} else {
-				delete this.container.title;
+				this.container.title = '';
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -746,11 +746,11 @@ export class CodeWindow extends Disposable implements ICodeWindow {`
`746`	`746`
`747`	`747`	`// Config (combination of process.argv and window configuration)`
`748`	`748`	`const environment = parseArgs(process.argv, OPTIONS);`
`749`		`- const config = Object.assign(environment, windowConfiguration);`
	`749`	`+ const config = Object.assign(environment, windowConfiguration) as unknown as { [key: string]: unknown };`
`750`	`750`	`for (const key in config) {`
`751`		`- const configValue = (config as any)[key];`
	`751`	`+ const configValue = config[key];`
`752`	`752`	`if (configValue === undefined \|\| configValue === null \|\| configValue === '' \|\| configValue === false) {`
`753`		`- delete (config as any)[key]; // only send over properties that have a true value`
	`753`	`+ delete config[key]; // only send over properties that have a true value`
`754`	`754`	`}`
`755`	`755`	`}`
`756`	`756`
Original file line number	Diff line number	Diff line change
`@@ -703,7 +703,7 @@ class StatusbarEntryItem extends Disposable {`
`703`	`703`	`if (entry.tooltip) {`
`704`	`704`	`this.container.title = entry.tooltip;`
`705`	`705`	`} else {`
`706`		`- delete this.container.title;`
	`706`	`+ this.container.title = '';`
`707`	`707`	`}`
`708`	`708`	`}`
`709`	`709`