fix microsoft#59333

jrieken · jrieken · commit 6f60df4d8a4c · 2018-09-26T11:04:24.000+02:00
diff --git a/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts b/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts
@@ -365,7 +365,7 @@ export class BreadcrumbsControl {
 				let pickerArrowOffset: number;
 
 				let data = dom.getDomNodePagePosition(event.node.firstChild as HTMLElement);
-				let y = data.top + data.height - pickerArrowSize;
+				let y = data.top + data.height + pickerArrowSize;
 				if (y + maxHeight >= window.innerHeight) {
 					maxHeight = window.innerHeight - y - 30 /* room for shadow and status bar*/;
 				}
diff --git a/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts b/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts
@@ -80,9 +80,7 @@ export abstract class BreadcrumbsPicker {
 		const color = theme.getColor(breadcrumbsPickerBackground);
 
 		this._arrow = document.createElement('div');
-		this._arrow.style.width = '0';
-		this._arrow.style.borderStyle = 'solid';
-		this._arrow.style.borderWidth = '8px';
+		this._arrow.className = 'arrow';
 		this._arrow.style.borderColor = `transparent transparent ${color.toString()}`;
 		this._domNode.appendChild(this._arrow);
 
@@ -186,6 +184,7 @@ export abstract class BreadcrumbsPicker {
 
 		this._domNode.style.height = `${totalHeight}px`;
 		this._domNode.style.width = `${info.width}px`;
+		this._arrow.style.top = `-${2 * info.arrowSize}px`;
 		this._arrow.style.borderWidth = `${info.arrowSize}px`;
 		this._arrow.style.marginLeft = `${info.arrowOffset}px`;
 		this._treeContainer.style.height = `${treeHeight}px`;
diff --git a/src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css b/src/vs/workbench/browser/parts/editor/media/breadcrumbscontrol.css
@@ -19,6 +19,12 @@
 
 /* todo@joh move somewhere else */
 
+.monaco-workbench .monaco-breadcrumbs-picker .arrow {
+	position: absolute;
+	width: 0;
+	border-style: solid;
+}
+
 .monaco-workbench .monaco-breadcrumbs-picker .picker-item {
 	line-height: 22px;
 	flex: 1;

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ export class BreadcrumbsControl {`
`365`	`365`	`let pickerArrowOffset: number;`
`366`	`366`
`367`	`367`	`let data = dom.getDomNodePagePosition(event.node.firstChild as HTMLElement);`
`368`		`- let y = data.top + data.height - pickerArrowSize;`
	`368`	`+ let y = data.top + data.height + pickerArrowSize;`
`369`	`369`	`if (y + maxHeight >= window.innerHeight) {`
`370`	`370`	`maxHeight = window.innerHeight - y - 30 /* room for shadow and status bar*/;`
`371`	`371`	`}`