Skip to content

Commit 6db9773

Browse files
committed
remove legacy API
1 parent cb1c577 commit 6db9773

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

src/vs/vscode.proposed.d.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1912,11 +1912,6 @@ declare module 'vscode' {
19121912
// backup?(document: NotebookDocument, cancellation: CancellationToken): Thenable<CustomDocumentBackup>;
19131913

19141914
kernel?: NotebookKernel;
1915-
1916-
/**
1917-
* Responsible for filling in outputs for the cell
1918-
*/
1919-
executeCell(document: NotebookDocument, cell: NotebookCell | undefined, token: CancellationToken): Promise<void>;
19201915
}
19211916

19221917
export interface NotebookKernel {

src/vs/workbench/api/common/extHostNotebook.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -807,6 +807,10 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
807807
throw new Error(`Notebook provider for '${viewType}' already registered`);
808808
}
809809

810+
if ((<any>provider).executeCell) {
811+
throw new Error('NotebookContentKernel.executeCell is removed, please use vscode.notebook.registerNotebookKernel instead.');
812+
}
813+
810814
this._notebookContentProviders.set(viewType, { extension, provider });
811815
this._proxy.$registerNotebookProvider({ id: extension.identifier, location: extension.extensionLocation }, viewType, provider.kernel ? { id: viewType, label: provider.kernel.label, extensionLocation: extension.extensionLocation, preloads: provider.kernel.preloads } : undefined);
812816
return new extHostTypes.Disposable(() => {
@@ -963,8 +967,6 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
963967
} else {
964968
return provider.kernel.executeAllCells(document, token);
965969
}
966-
} else {
967-
return provider.executeCell(document, cell, token);
968970
}
969971
}
970972
}

0 commit comments

Comments
 (0)