remove legacy API

rebornix · rebornix · commit 6db9773a328a · 2020-05-20T09:02:47.000-07:00
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -1912,11 +1912,6 @@ declare module 'vscode' {
 		// backup?(document: NotebookDocument, cancellation: CancellationToken): Thenable<CustomDocumentBackup>;
 
 		kernel?: NotebookKernel;
-
-		/**
-		 * Responsible for filling in outputs for the cell
-		 */
-		executeCell(document: NotebookDocument, cell: NotebookCell | undefined, token: CancellationToken): Promise<void>;
 	}
 
 	export interface NotebookKernel {
diff --git a/src/vs/workbench/api/common/extHostNotebook.ts b/src/vs/workbench/api/common/extHostNotebook.ts
@@ -807,6 +807,10 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 			throw new Error(`Notebook provider for '${viewType}' already registered`);
 		}
 
+		if ((<any>provider).executeCell) {
+			throw new Error('NotebookContentKernel.executeCell is removed, please use vscode.notebook.registerNotebookKernel instead.');
+		}
+
 		this._notebookContentProviders.set(viewType, { extension, provider });
 		this._proxy.$registerNotebookProvider({ id: extension.identifier, location: extension.extensionLocation }, viewType, provider.kernel ? { id: viewType, label: provider.kernel.label, extensionLocation: extension.extensionLocation, preloads: provider.kernel.preloads } : undefined);
 		return new extHostTypes.Disposable(() => {
@@ -963,8 +967,6 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 				} else {
 					return provider.kernel.executeAllCells(document, token);
 				}
-			} else {
-				return provider.executeCell(document, cell, token);
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -807,6 +807,10 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN`
`807`	`807`	throw new Error(`Notebook provider for '${viewType}' already registered`);
`808`	`808`	`}`
`809`	`809`
	`810`	`+ if ((<any>provider).executeCell) {`
	`811`	`+ throw new Error('NotebookContentKernel.executeCell is removed, please use vscode.notebook.registerNotebookKernel instead.');`
	`812`	`+ }`
	`813`	`+`
`810`	`814`	`this._notebookContentProviders.set(viewType, { extension, provider });`
`811`	`815`	`this._proxy.$registerNotebookProvider({ id: extension.identifier, location: extension.extensionLocation }, viewType, provider.kernel ? { id: viewType, label: provider.kernel.label, extensionLocation: extension.extensionLocation, preloads: provider.kernel.preloads } : undefined);`
`812`	`816`	`return new extHostTypes.Disposable(() => {`
`@@ -963,8 +967,6 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN`
`963`	`967`	`} else {`
`964`	`968`	`return provider.kernel.executeAllCells(document, token);`
`965`	`969`	`}`
`966`		`- } else {`
`967`		`- return provider.executeCell(document, cell, token);`
`968`	`970`	`}`
`969`	`971`	`}`
`970`	`972`	`}`