Skip to content

Commit 69b1bfb

Browse files
committed
update with changes on master
1 parent 1d658de commit 69b1bfb

5 files changed

Lines changed: 249 additions & 124 deletions

File tree

src/vs/workbench/services/extensions/electron-browser/extensionService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ export class ExtensionService extends AbstractExtensionService implements IExten
350350
}
351351

352352
const result: ExtensionHostProcessManager[] = [];
353-
const workerExtensions = { ['jrieken.helloworld']: true };
353+
const workerExtensions: Record<string, true> = { ['jrieken.helloworld']: true };
354354

355355
const extHostProcessWorker = this._instantiationService.createInstance(ExtensionHostProcessWorker, autoStart, extensions.then(e => e.filter(e => !workerExtensions[e.identifier.value])), this._extensionHostLogsLocation);
356356
const extHostProcessManager = this._instantiationService.createInstance(ExtensionHostProcessManager, true, extHostProcessWorker, null, initialActivationEvents);

src/vs/workbench/services/extensions/electron-browser/webWorkerExtensionHostStarter.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
1717
import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace';
1818
import { ILabelService } from 'vs/platform/label/common/label';
1919
import { ILogService } from 'vs/platform/log/common/log';
20-
import { IEnvironmentService } from 'vs/platform/environment/common/environment';
2120
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
2221
import * as platform from 'vs/base/common/platform';
2322
import { URI } from 'vs/base/common/uri';
2423
import { IExtensionHostStarter } from 'vs/workbench/services/extensions/common/extensions';
2524
import { IProductService } from 'vs/platform/product/common/product';
25+
import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';
2626

2727
export class WebWorkerExtensionHostStarter implements IExtensionHostStarter {
2828

@@ -41,7 +41,7 @@ export class WebWorkerExtensionHostStarter implements IExtensionHostStarter {
4141
@IWorkspaceContextService private readonly _contextService: IWorkspaceContextService,
4242
@ILabelService private readonly _labelService: ILabelService,
4343
@ILogService private readonly _logService: ILogService,
44-
@IEnvironmentService private readonly _environmentService: IEnvironmentService,
44+
@IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService,
4545
@IProductService private readonly _productService: IProductService,
4646
) {
4747

@@ -121,14 +121,16 @@ export class WebWorkerExtensionHostStarter implements IExtensionHostStarter {
121121
environment: {
122122
isExtensionDevelopmentDebug: false, // < todo@joh
123123
appRoot: this._environmentService.appRoot ? URI.file(this._environmentService.appRoot) : undefined,
124-
appSettingsHome: this._environmentService.appSettingsHome ? URI.file(this._environmentService.appSettingsHome) : undefined,
124+
appSettingsHome: this._environmentService.appSettingsHome ? this._environmentService.appSettingsHome : undefined,
125125
appName: this._productService.nameLong,
126126
appUriScheme: this._productService.urlProtocol,
127127
appLanguage: platform.language,
128128
extensionDevelopmentLocationURI: this._environmentService.extensionDevelopmentLocationURI,
129129
extensionTestsLocationURI: this._environmentService.extensionTestsLocationURI,
130130
globalStorageHome: URI.file(this._environmentService.globalStorageHome),
131-
userHome: URI.file(this._environmentService.userHome)
131+
userHome: URI.file(this._environmentService.userHome),
132+
webviewResourceRoot: this._environmentService.webviewResourceRoot,
133+
webviewCspSource: this._environmentService.webviewCspSource,
132134
},
133135
workspace: this._contextService.getWorkbenchState() === WorkbenchState.EMPTY ? undefined : {
134136
configuration: workspace.configuration || undefined,
@@ -141,7 +143,11 @@ export class WebWorkerExtensionHostStarter implements IExtensionHostStarter {
141143
telemetryInfo,
142144
logLevel: this._logService.getLevel(),
143145
logsLocation: this._extensionHostLogsLocation,
144-
autoStart: true// < todo@joh this._autoStart
146+
autoStart: true,// < todo@joh this._autoStart,
147+
remote: {
148+
authority: this._environmentService.configuration.remoteAuthority,
149+
isRemote: false
150+
},
145151
};
146152
return r;
147153
});

0 commit comments

Comments
 (0)