Cannot read property 'dispose' of undefined (fixes microsoft#4576)

Benjamin Pasero · Benjamin Pasero · commit 69682cabda74 · 2016-03-23T15:01:45.000+01:00
diff --git a/src/vs/base/parts/quickopen/browser/quickOpenModel.ts b/src/vs/base/parts/quickopen/browser/quickOpenModel.ts
@@ -650,21 +650,21 @@ class Renderer implements IRenderer<QuickOpenEntry> {
 	public disposeTemplate(templateId: string, templateData: any): void {
 		if (templateId === templateEntryItem) {
 			this.entryItemRenderer.disposeTemplate(null, templateId, templateData);
+		} else {
+			const data = templateData as IQuickOpenEntryGroupTemplateData;
+			data.actionBar.dispose();
+			data.actionBar = null;
+			data.container = null;
+			data.description.dispose();
+			data.description = null;
+			data.detail.dispose();
+			data.detail = null;
+			data.group = null;
+			data.icon = null;
+			data.label.dispose();
+			data.label = null;
+			data.prefix = null;
 		}
-
-		const data = templateData as IQuickOpenEntryGroupTemplateData;
-		data.actionBar.dispose();
-		data.actionBar = null;
-		data.container = null;
-		data.description.dispose();
-		data.description = null;
-		data.detail.dispose();
-		data.detail = null;
-		data.group = null;
-		data.icon = null;
-		data.label.dispose();
-		data.label = null;
-		data.prefix = null;
 	}
 }
 
