Fix treeshaking, not all export clauses should be kept

alexdima · alexdima · commit 68351085dbbe · 2020-03-05T10:25:06.000+01:00
diff --git a/build/lib/treeshaking.js b/build/lib/treeshaking.js
@@ -265,7 +265,8 @@ function markNodes(languageService, options) {
                 return;
             }
             if (ts.isExportDeclaration(node)) {
-                if (node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {
+                if (!node.exportClause && node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {
+                    // export * from "foo";
                     setColor(node, 2 /* Black */);
                     enqueueImport(node, node.moduleSpecifier.text);
                 }
diff --git a/build/lib/treeshaking.ts b/build/lib/treeshaking.ts
@@ -351,7 +351,8 @@ function markNodes(languageService: ts.LanguageService, options: ITreeShakingOpt
 			}
 
 			if (ts.isExportDeclaration(node)) {
-				if (node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {
+				if (!node.exportClause && node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {
+					// export * from "foo";
 					setColor(node, NodeColor.Black);
 					enqueueImport(node, node.moduleSpecifier.text);
 				}

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,8 @@ function markNodes(languageService, options) {`
`265`	`265`	`return;`
`266`	`266`	`}`
`267`	`267`	`if (ts.isExportDeclaration(node)) {`
`268`		`- if (node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {`
	`268`	`+ if (!node.exportClause && node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {`
	`269`	`+ // export * from "foo";`
`269`	`270`	`setColor(node, 2 /* Black */);`
`270`	`271`	`enqueueImport(node, node.moduleSpecifier.text);`
`271`	`272`	`}`
Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,8 @@ function markNodes(languageService: ts.LanguageService, options: ITreeShakingOpt`
`351`	`351`	`}`
`352`	`352`
`353`	`353`	`if (ts.isExportDeclaration(node)) {`
`354`		`- if (node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {`
	`354`	`+ if (!node.exportClause && node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier)) {`
	`355`	`+ // export * from "foo";`
`355`	`356`	`setColor(node, NodeColor.Black);`
`356`	`357`	`enqueueImport(node, node.moduleSpecifier.text);`
`357`	`358`	`}`