Fix/supress more implict index errors

mjbvz · mjbvz · commit 6824cc90231d · 2019-07-08T18:27:09.000-07:00
microsoft#76442
diff --git a/src/vs/platform/diagnostics/common/diagnosticsService.ts b/src/vs/platform/diagnostics/common/diagnosticsService.ts
@@ -8,6 +8,7 @@ import { ProcessItem } from 'vs/base/common/processes';
 import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
 import { IMainProcessInfo } from 'vs/platform/launch/common/launchService';
 import { IWorkspace } from 'vs/platform/workspace/common/workspace';
+import { IStringDictionary } from 'vs/base/common/collections';
 
 export interface IMachineInfo {
 	os: string;
@@ -18,7 +19,7 @@ export interface IMachineInfo {
 
 export interface IDiagnosticInfo {
 	machineInfo: IMachineInfo;
-	workspaceMetadata?: { [key: string]: WorkspaceStats };
+	workspaceMetadata?: IStringDictionary<WorkspaceStats>;
 	processes?: ProcessItem;
 }
 export interface SystemInfo extends IMachineInfo {
diff --git a/src/vs/workbench/contrib/markers/browser/markersPanelActions.ts b/src/vs/workbench/contrib/markers/browser/markersPanelActions.ts
@@ -275,10 +275,11 @@ export class MarkersFilterActionViewItem extends BaseActionViewItem {
 
 	private reportFilteringUsed(): void {
 		const filterOptions = this.filterController.getFilterOptions();
-		const data = {};
-		data['errors'] = filterOptions.filterErrors;
-		data['warnings'] = filterOptions.filterWarnings;
-		data['infos'] = filterOptions.filterInfos;
+		const data = {
+			errors: filterOptions.filterErrors,
+			warnings: filterOptions.filterWarnings,
+			infos: filterOptions.filterInfos,
+		};
 		/* __GDPR__
 			"problems.filter" : {
 				"errors" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
diff --git a/src/vs/workbench/contrib/output/browser/outputPanel.ts b/src/vs/workbench/contrib/output/browser/outputPanel.ts
@@ -95,7 +95,7 @@ export class OutputPanel extends AbstractTextResourceEditor {
 		options.renderLineHighlight = 'none';
 		options.minimap = { enabled: false };
 
-		const outputConfig = this.baseConfigurationService.getValue<{}>('[Log]');
+		const outputConfig = this.baseConfigurationService.getValue<any>('[Log]');
 		if (outputConfig) {
 			if (outputConfig['editor.minimap.enabled']) {
 				options.minimap = { enabled: true };
diff --git a/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts b/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts
@@ -284,7 +284,7 @@ export class PreferencesEditor extends BaseEditor {
 	}
 
 	private _countById(settingsGroups: ISettingsGroup[]): IStringDictionary<number> {
-		const result = {};
+		const result: IStringDictionary<number> = {};
 
 		for (const group of settingsGroups) {
 			let i = 0;
@@ -680,7 +680,7 @@ class PreferencesRenderersController extends Disposable {
 	}
 
 	private _updatePreference(key: string, value: any, source: ISetting, fromEditableSettings?: boolean): void {
-		const data = {
+		const data: { [key: string]: any } = {
 			userConfigurationKeys: [key]
 		};
 

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ export class PreferencesEditor extends BaseEditor {`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`private _countById(settingsGroups: ISettingsGroup[]): IStringDictionary<number> {`
`287`		`- const result = {};`
	`287`	`+ const result: IStringDictionary<number> = {};`
`288`	`288`
`289`	`289`	`for (const group of settingsGroups) {`
`290`	`290`	`let i = 0;`
`@@ -680,7 +680,7 @@ class PreferencesRenderersController extends Disposable {`
`680`	`680`	`}`
`681`	`681`
`682`	`682`	`private _updatePreference(key: string, value: any, source: ISetting, fromEditableSettings?: boolean): void {`
`683`		`- const data = {`
	`683`	`+ const data: { [key: string]: any } = {`
`684`	`684`	`userConfigurationKeys: [key]`
`685`	`685`	`};`
`686`	`686`