Skip to content

Commit 67bd6f0

Browse files
committed
Towards simplifying MouseTargetFactory
1 parent eac9ada commit 67bd6f0

3 files changed

Lines changed: 300 additions & 208 deletions

File tree

src/vs/editor/browser/controller/mouseHandler.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -453,23 +453,23 @@ class MouseDownOperation extends Disposable {
453453

454454
let mouseColumn = this._getMouseColumn(e);
455455

456-
if (e.posy < editorContent.top) {
457-
let aboveLineNumber = this._viewHelper.getLineNumberAtVerticalOffset(Math.max(this._viewHelper.getScrollTop() - (editorContent.top - e.posy), 0));
456+
if (e.posy < editorContent.y) {
457+
let aboveLineNumber = this._viewHelper.getLineNumberAtVerticalOffset(Math.max(this._viewHelper.getScrollTop() - (editorContent.y - e.posy), 0));
458458
return new MousePosition(new Position(aboveLineNumber, 1), mouseColumn);
459459
}
460460

461-
if (e.posy > editorContent.top + editorContent.height) {
462-
let belowLineNumber = this._viewHelper.getLineNumberAtVerticalOffset(this._viewHelper.getScrollTop() + (e.posy - editorContent.top));
461+
if (e.posy > editorContent.y + editorContent.height) {
462+
let belowLineNumber = this._viewHelper.getLineNumberAtVerticalOffset(this._viewHelper.getScrollTop() + (e.posy - editorContent.y));
463463
return new MousePosition(new Position(belowLineNumber, this._context.model.getLineMaxColumn(belowLineNumber)), mouseColumn);
464464
}
465465

466-
let possibleLineNumber = this._viewHelper.getLineNumberAtVerticalOffset(this._viewHelper.getScrollTop() + (e.posy - editorContent.top));
466+
let possibleLineNumber = this._viewHelper.getLineNumberAtVerticalOffset(this._viewHelper.getScrollTop() + (e.posy - editorContent.y));
467467

468-
if (e.posx < editorContent.left) {
468+
if (e.posx < editorContent.x) {
469469
return new MousePosition(new Position(possibleLineNumber, 1), mouseColumn);
470470
}
471471

472-
if (e.posx > editorContent.left + editorContent.width) {
472+
if (e.posx > editorContent.x + editorContent.width) {
473473
return new MousePosition(new Position(possibleLineNumber, this._context.model.getLineMaxColumn(possibleLineNumber)), mouseColumn);
474474
}
475475

0 commit comments

Comments
 (0)