Skip to content

Commit 6528137

Browse files
committed
extensions with debuggers defaults to workspace extension
1 parent d098313 commit 6528137

1 file changed

Lines changed: 14 additions & 1 deletion

File tree

src/vs/platform/extensions/common/extensions.ts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { IConfigurationService } from 'vs/platform/configuration/common/configur
77
import { IExtensionManifest } from 'vs/platform/extensionManagement/common/extensionManagement';
88
import { getGalleryExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
99
import * as strings from 'vs/base/common/strings';
10+
import { isNonEmptyArray } from 'vs/base/common/arrays';
1011

1112
export const MANIFEST_CACHE_FOLDER = 'CachedExtensions';
1213
export const USER_MANIFEST_CACHE_FILE = 'user';
@@ -29,7 +30,19 @@ export function isUIExtension(manifest: IExtensionManifest, configurationService
2930
switch (manifest.extensionKind) {
3031
case 'ui': return true;
3132
case 'workspace': return false;
32-
default: return uiExtensions.has(extensionId) || !manifest.main;
33+
default: {
34+
if (uiExtensions.has(extensionId)) {
35+
return true;
36+
}
37+
if (manifest.main) {
38+
return false;
39+
}
40+
if (manifest.contributes && isNonEmptyArray(manifest.contributes.debuggers)) {
41+
return false;
42+
}
43+
// Default is UI Extension
44+
return true;
45+
}
3346
}
3447
}
3548

0 commit comments

Comments
 (0)