remove openOnSelection

joaomoreno · joaomoreno · commit 64fa33d36a6c · 2020-06-15T16:12:43.000+02:00
diff --git a/src/vs/platform/list/browser/listService.ts b/src/vs/platform/list/browser/listService.ts
@@ -412,7 +412,6 @@ export interface IOpenEvent<T> {
 export interface IResourceNavigatorOptions {
 	readonly configurationService?: IConfigurationService;
 	readonly openOnFocus?: boolean;
-	readonly openOnSelection?: boolean;
 	readonly openOnSingleClick?: boolean;
 }
 
@@ -430,7 +429,6 @@ export function getSelectionKeyboardEvent(typeArg = 'keydown', preserveFocus?: b
 abstract class ResourceNavigator<T> extends Disposable {
 
 	private readonly openOnFocus: boolean;
-	private readonly openOnSelection: boolean;
 	private openOnSingleClick: boolean;
 
 	private readonly _onDidOpen = new Emitter<IOpenEvent<T | null>>();
@@ -443,19 +441,15 @@ abstract class ResourceNavigator<T> extends Disposable {
 		super();
 
 		this.openOnFocus = options?.openOnFocus ?? false;
-		this.openOnSelection = options?.openOnSelection ?? true;
 		this.openOnSingleClick = options?.openOnSingleClick ?? true;
 
+		this._register(this.widget.onDidChangeSelection(e => this.onSelection(e)));
+		this._register(this.widget.onMouseDblClick((e: { browserEvent: MouseEvent }) => this.onMouseDblClick(e.browserEvent)));
+
 		if (this.openOnFocus) {
 			this._register(this.widget.onDidChangeFocus(e => this.onFocus(e.browserEvent)));
 		}
 
-		if (this.openOnSelection) {
-			this._register(this.widget.onDidChangeSelection(e => this.onSelection(e)));
-		}
-
-		this._register(this.widget.onMouseDblClick((e: { browserEvent: MouseEvent }) => this.onMouseDblClick(e.browserEvent)));
-
 		if (typeof options?.openOnSingleClick !== 'boolean' && options?.configurationService) {
 			this._register(options?.configurationService.onDidChangeConfiguration(() => {
 				this.openOnSingleClick = options?.configurationService!.getValue(openModeSettingKey) !== 'doubleClick';
