API: Finalize env.uiKind (fixes microsoft#82883)

Benjamin Pasero · Benjamin Pasero · commit 62ea960353a3 · 2019-10-21T18:31:37.000+02:00
diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts
@@ -6177,6 +6177,22 @@ declare module 'vscode' {
 		writeText(value: string): Thenable<void>;
 	}
 
+	/**
+	 * Possible kinds of UI that can use extensions.
+	 */
+	export enum UIKind {
+
+		/**
+		 * Extensions are accessed from a desktop application.
+		 */
+		Desktop = 1,
+
+		/**
+		 * Extensions are accessed from a web browser.
+		 */
+		Web = 2
+	}
+
 	/**
 	 * Namespace describing the environment the editor runs in.
 	 */
@@ -6235,6 +6251,13 @@ declare module 'vscode' {
 		 */
 		export const shell: string;
 
+		/**
+		 * The UI kind property indicates from which UI extensions
+		 * are accessed from. For example, extensions could be accessed
+		 * from a desktop application or a web browser.
+		 */
+		export const uiKind: UIKind;
+
 		/**
 		 * Opens an *external* item, e.g. a http(s) or mailto-link, using the
 		 * default application.
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -1039,36 +1039,6 @@ declare module 'vscode' {
 
 	//#endregion
 
-	// #region Ben - UIKind
-
-	/**
-	 * Possible kinds of UI that can use extensions.
-	 */
-	export enum UIKind {
-
-		/**
-		 * Extensions are accessed from a desktop application.
-		 */
-		Desktop = 1,
-
-		/**
-		 * Extensions are accessed from a web browser.
-		 */
-		Web = 2
-	}
-
-	export namespace env {
-
-		/**
-		 * The UI kind property indicates from which UI extensions
-		 * are accessed from. For example, extensions could be accessed
-		 * from a desktop application or a web browser.
-		 */
-		export const uiKind: UIKind;
-	}
-
-	//#endregion
-
 	//#region Custom editors, mjbvz
 
 	export interface WebviewEditor extends WebviewPanel {
diff --git a/src/vs/workbench/api/common/extHost.api.impl.ts b/src/vs/workbench/api/common/extHost.api.impl.ts
@@ -255,7 +255,6 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
 				return getRemoteName(initData.remote.authority);
 			},
 			get uiKind() {
-				checkProposedApiEnabled(extension);
 				return initData.uiKind;
 			}
 		};

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,6 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I`
`255`	`255`	`return getRemoteName(initData.remote.authority);`
`256`	`256`	`},`
`257`	`257`	`get uiKind() {`
`258`		`- checkProposedApiEnabled(extension);`
`259`	`258`	`return initData.uiKind;`
`260`	`259`	`}`
`261`	`260`	`};`