debug: if noDebug is not passed take behavrior of parent session

isidorn · isidorn · commit 61dcbfc29b36 · 2020-06-12T17:32:28.000+02:00
microsoft#99743
diff --git a/src/vs/workbench/contrib/debug/browser/debugService.ts b/src/vs/workbench/contrib/debug/browser/debugService.ts
@@ -373,7 +373,11 @@ export class DebugService implements IDebugService {
 			config = Object.create(null);
 		}
 		if (options && options.noDebug) {
-			options.noDebug = true;
+			config!.noDebug = true;
+		} else if (options && typeof options.noDebug === 'undefined' && options.parentSession && options.parentSession.configuration.noDebug) {
+			config!.noDebug = true;
+		} else {
+			delete config!.noDebug;
 		}
 		const unresolvedConfig = deepClone(config);
 

Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,11 @@ export class DebugService implements IDebugService {`
`373`	`373`	`config = Object.create(null);`
`374`	`374`	`}`
`375`	`375`	`if (options && options.noDebug) {`
`376`		`- options.noDebug = true;`
	`376`	`+ config!.noDebug = true;`
	`377`	`+ } else if (options && typeof options.noDebug === 'undefined' && options.parentSession && options.parentSession.configuration.noDebug) {`
	`378`	`+ config!.noDebug = true;`
	`379`	`+ } else {`
	`380`	`+ delete config!.noDebug;`
`377`	`381`	`}`
`378`	`382`	`const unresolvedConfig = deepClone(config);`
`379`	`383`