Add logging of PATH to investigate ATA issues reported in microsoft#24961

mjbvz · mjbvz · commit 613724d43b4d · 2017-05-15T21:46:21.000-07:00
diff --git a/extensions/typescript/src/typescriptServiceClient.ts b/extensions/typescript/src/typescriptServiceClient.ts
@@ -543,7 +543,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
 						}
 					}
 
-					electron.fork(modulePath, args, options, (err: any, childProcess: cp.ChildProcess) => {
+					electron.fork(modulePath, args, options, this.logger, (err: any, childProcess: cp.ChildProcess) => {
 						if (err) {
 							this.lastError = err;
 							this.error('Starting TSServer failed with error.', err);
diff --git a/extensions/typescript/src/utils/electron.ts b/extensions/typescript/src/utils/electron.ts
@@ -9,6 +9,7 @@ import path = require('path');
 import os = require('os');
 import net = require('net');
 import cp = require('child_process');
+import Logger from './logger';
 
 export interface IForkOptions {
 	cwd?: string;
@@ -60,7 +61,8 @@ export function fork(
 	modulePath: string,
 	args: string[],
 	options: IForkOptions,
-	callback: (error: any, cp: cp.ChildProcess | null) => void
+	logger: Logger,
+	callback: (error: any, cp: cp.ChildProcess | null) => void,
 ): void {
 
 	var callbackCalled = false;
@@ -86,7 +88,6 @@ export function fork(
 
 
 	const newEnv = generatePatchedEnv(process.env, stdInPipeName, stdOutPipeName, stdErrPipeName);
-
 	var childProcess: cp.ChildProcess;
 
 	// Begin listening to stderr pipe
@@ -123,6 +124,8 @@ export function fork(
 	};
 
 	// Create the process
+	logger.info('Forking TSServer', `PATH: ${newEnv['PATH']}`);
+
 	const bootstrapperPath = path.join(__dirname, 'electronForkStart');
 	childProcess = cp.fork(bootstrapperPath, [modulePath].concat(args), <any>{
 		silent: true,

Original file line number	Diff line number	Diff line change
`@@ -543,7 +543,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient`
`543`	`543`	`}`
`544`	`544`	`}`
`545`	`545`
`546`		`- electron.fork(modulePath, args, options, (err: any, childProcess: cp.ChildProcess) => {`
	`546`	`+ electron.fork(modulePath, args, options, this.logger, (err: any, childProcess: cp.ChildProcess) => {`
`547`	`547`	`if (err) {`
`548`	`548`	`this.lastError = err;`
`549`	`549`	`this.error('Starting TSServer failed with error.', err);`