Uplevel xterm.js

Tyriar · Tyriar · commit 609ea97d0c88 · 2017-11-04T21:05:31.000-07:00
Brings in an API breakage
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -44,7 +44,7 @@
     "vscode-debugprotocol": "1.24.0",
     "vscode-ripgrep": "0.6.0-patch.0",
     "vscode-textmate": "^3.2.0",
-    "xterm": "Tyriar/xterm.js#vscode-release/1.18",
+    "xterm": "Tyriar/xterm.js#vscode-release/1.19",
     "yauzl": "2.8.0"
   },
   "devDependencies": {
diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts b/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts
@@ -534,7 +534,7 @@ export class TerminalInstance implements ITerminalInstance {
 	}
 
 	public scrollDownLine(): void {
-		this._xterm.scrollDisp(1);
+		this._xterm.scrollLines(1);
 	}
 
 	public scrollDownPage(): void {
@@ -546,7 +546,7 @@ export class TerminalInstance implements ITerminalInstance {
 	}
 
 	public scrollUpLine(): void {
-		this._xterm.scrollDisp(-1);
+		this._xterm.scrollLines(-1);
 	}
 
 	public scrollUpPage(): void {

Original file line number	Diff line number	Diff line change
`@@ -534,7 +534,7 @@ export class TerminalInstance implements ITerminalInstance {`
`534`	`534`	`}`
`535`	`535`
`536`	`536`	`public scrollDownLine(): void {`
`537`		`- this._xterm.scrollDisp(1);`
	`537`	`+ this._xterm.scrollLines(1);`
`538`	`538`	`}`
`539`	`539`
`540`	`540`	`public scrollDownPage(): void {`
`@@ -546,7 +546,7 @@ export class TerminalInstance implements ITerminalInstance {`
`546`	`546`	`}`
`547`	`547`
`548`	`548`	`public scrollUpLine(): void {`
`549`		`- this._xterm.scrollDisp(-1);`
	`549`	`+ this._xterm.scrollLines(-1);`
`550`	`550`	`}`
`551`	`551`
`552`	`552`	`public scrollUpPage(): void {`