💄 microsoft#29076

jrieken · jrieken · commit 60892e5fa813 · 2017-08-23T16:18:14.000+02:00
diff --git a/src/vs/base/common/htmlContent.ts b/src/vs/base/common/htmlContent.ts
@@ -33,15 +33,11 @@ export class MarkdownString implements IMarkdownString {
 	}
 
 	appendText(value: string): this {
-		this.value += textToMarkedString(value);
+		// escape markdown syntax tokens: http://daringfireball.net/projects/markdown/syntax#backslash
+		this.value += value.replace(/[\\`*_{}[\]()#+\-.!]/g, '\\$&');
 		return this;
 	}
 
-	// appendMarkdown(value: string): this {
-	// 	this.value += value;
-	// 	return this;
-	// }
-
 	appendCodeblock(langId: string, code: string): this {
 		this.value += '```';
 		this.value += langId;
@@ -76,10 +72,6 @@ function markdownStringEqual(a: IMarkdownString, b: IMarkdownString): boolean {
 	}
 }
 
-export function textToMarkedString(text: string): string {
-	return text.replace(/[\\`*_{}[\]()#+\-.!]/g, '\\$&'); // escape markdown syntax tokens: http://daringfireball.net/projects/markdown/syntax#backslash
-}
-
 export function removeMarkdownEscapes(text: string): string {
 	if (!text) {
 		return text;
diff --git a/src/vs/editor/common/services/modelServiceImpl.ts b/src/vs/editor/common/services/modelServiceImpl.ts
@@ -8,7 +8,7 @@ import * as nls from 'vs/nls';
 import network = require('vs/base/common/network');
 import Event, { Emitter } from 'vs/base/common/event';
 import { EmitterEvent } from 'vs/base/common/eventEmitter';
-import { IMarkdownString } from 'vs/base/common/htmlContent';
+import { MarkdownString } from 'vs/base/common/htmlContent';
 import { IDisposable } from 'vs/base/common/lifecycle';
 import Severity from 'vs/base/common/severity';
 import URI from 'vs/base/common/uri';
@@ -136,7 +136,7 @@ class ModelMarkerHandler {
 				break;
 		}
 
-		let hoverMessage: IMarkdownString = null;
+		let hoverMessage: MarkdownString = null;
 		let { message, source } = marker;
 
 		if (typeof message === 'string') {
@@ -150,7 +150,7 @@ class ModelMarkerHandler {
 				}
 			}
 
-			hoverMessage = { value: '```_\n' + message + '\n```' };
+			hoverMessage = new MarkdownString().appendCodeblock('_', message);
 		}
 
 		return {

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import * as nls from 'vs/nls';`
`8`	`8`	`import network = require('vs/base/common/network');`
`9`	`9`	`import Event, { Emitter } from 'vs/base/common/event';`
`10`	`10`	`import { EmitterEvent } from 'vs/base/common/eventEmitter';`
`11`		`-import { IMarkdownString } from 'vs/base/common/htmlContent';`
	`11`	`+import { MarkdownString } from 'vs/base/common/htmlContent';`
`12`	`12`	`import { IDisposable } from 'vs/base/common/lifecycle';`
`13`	`13`	`import Severity from 'vs/base/common/severity';`
`14`	`14`	`import URI from 'vs/base/common/uri';`
`@@ -136,7 +136,7 @@ class ModelMarkerHandler {`
`136`	`136`	`break;`
`137`	`137`	`}`
`138`	`138`
`139`		`- let hoverMessage: IMarkdownString = null;`
	`139`	`+ let hoverMessage: MarkdownString = null;`
`140`	`140`	`let { message, source } = marker;`
`141`	`141`
`142`	`142`	`if (typeof message === 'string') {`
`@@ -150,7 +150,7 @@ class ModelMarkerHandler {`
`150`	`150`	`}`
`151`	`151`	`}`
`152`	`152`
`153`		- hoverMessage = { value: '```_\n' + message + '\n```' };
	`153`	`+ hoverMessage = new MarkdownString().appendCodeblock('_', message);`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`return {`