Skip to content

Commit 602155b

Browse files
committed
Avoid backticks (fixes microsoft#13098)
1 parent c968226 commit 602155b

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/vs/workbench/electron-browser/actions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,12 +521,13 @@ export class ReportIssueAction extends Action {
521521
}
522522

523523
private generateNewIssueUrl(baseUrl: string, name: string, version: string, commit: string, date: string, isPure: boolean, extensions:ILocalExtension[]): string {
524+
// Avoid backticks, these can trigger XSS detectors. (https://github.com/Microsoft/vscode/issues/13098)
524525
const osVersion = `${os.type()} ${os.arch()} ${os.release()}`;
525526
const queryStringPrefix = baseUrl.indexOf('?') === -1 ? '?' : '&';
526527
const body = encodeURIComponent(
527528
`- VSCode Version: ${name} ${version}${isPure ? '' : ' **[Unsupported]**'} (${product.commit || 'Commit unknown'}, ${product.date || 'Date unknown'})
528529
- OS Version: ${osVersion}
529-
- Extensions: ${extensions.map(e => '`' + e.id + '`').join(', ')}
530+
- Extensions: ${extensions.map(e => e.id).join(', ')}
530531
531532
Steps to Reproduce:
532533

0 commit comments

Comments
 (0)