debt - remove out-dated or accepted todos

jrieken · jrieken · commit 5facf746acd6 · 2020-02-07T11:48:43.000+01:00
diff --git a/src/vs/base/test/common/uri.test.ts b/src/vs/base/test/common/uri.test.ts
@@ -404,7 +404,7 @@ suite('URI', () => {
 		path = 'foo/bar';
 		assert.equal(URI.file(path).path, '/foo/bar');
 		path = './foo/bar';
-		assert.equal(URI.file(path).path, '/./foo/bar'); // todo@joh missing normalization
+		assert.equal(URI.file(path).path, '/./foo/bar'); // missing normalization
 
 		const fileUri1 = URI.parse(`file:foo/bar`);
 		assert.equal(fileUri1.path, '/foo/bar');
diff --git a/src/vs/editor/common/services/editorWorkerServiceImpl.ts b/src/vs/editor/common/services/editorWorkerServiceImpl.ts
@@ -45,11 +45,13 @@ function canSyncModel(modelService: IModelService, resource: URI): boolean {
 }
 
 export class EditorWorkerServiceImpl extends Disposable implements IEditorWorkerService {
-	public _serviceBrand: undefined;
+
+	_serviceBrand: undefined;
 
 	private readonly _modelService: IModelService;
 	private readonly _workerManager: WorkerManager;
 	private readonly _logService: ILogService;
+
 	constructor(
 		@IModelService modelService: IModelService,
 		@ITextResourceConfigurationService configurationService: ITextResourceConfigurationService,
@@ -60,7 +62,7 @@ export class EditorWorkerServiceImpl extends Disposable implements IEditorWorker
 		this._workerManager = this._register(new WorkerManager(this._modelService));
 		this._logService = logService;
 
-		// todo@joh make sure this happens only once
+		// register default link-provider and default completions-provider
 		this._register(modes.LinkProviderRegistry.register('*', {
 			provideLinks: (model, token) => {
 				if (!canSyncModel(this._modelService, model.uri)) {
diff --git a/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts b/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts
@@ -402,7 +402,6 @@ export class BulkEditService implements IBulkEditService {
 		}
 
 		// try to find code editor
-		// todo@joh, prefer editor that gets edited
 		if (!codeEditor) {
 			let candidate = this._editorService.activeTextEditorWidget;
 			if (isCodeEditor(candidate)) {
diff --git a/src/vs/workbench/services/extensions/worker/extensionHostWorker.ts b/src/vs/workbench/services/extensions/worker/extensionHostWorker.ts
@@ -13,9 +13,7 @@ import { IHostUtils } from 'vs/workbench/api/common/extHostExtensionService';
 import 'vs/workbench/services/extensions/worker/extHost.services';
 
 //#region --- Define, capture, and override some globals
-//todo@joh do not allow extensions to call postMessage and other globals...
 
-// declare WorkerSelf#postMessage
 declare function postMessage(data: any, transferables?: Transferable[]): void;
 
 declare namespace self {
diff --git a/src/vs/workbench/services/timer/electron-browser/timerService.ts b/src/vs/workbench/services/timer/electron-browser/timerService.ts
@@ -227,8 +227,6 @@ export interface IStartupMetrics {
 		 * * Reading of package.json-files is avoided by caching them all in a single file (after the read,
 		 * until another extension is installed)
 		 * * Happens in parallel to other things, depends on async timing
-		 *
-		 * todo@joh/ramya this measures an artifical dealy we have added, see https://github.com/Microsoft/vscode/blob/2f07ddae8bf56e969e3f4ba1447258ebc999672f/src/vs/workbench/services/extensions/electron-browser/extensionService.ts#L311-L326
 		 */
 		readonly ellapsedExtensions: number;
 
@@ -264,8 +262,6 @@ export interface IStartupMetrics {
 		 * * Measured with the `willRestoreEditors` and `didRestoreEditors` performance marks.
 		 * * This should be looked at per editor and per editor type.
 		 * * Happens in parallel to other things, depends on async timing
-		 *
-		 * todo@joh/ramya We should probably measures each editor individually?
 		 */
 		readonly ellapsedEditorRestore: number;
 
@@ -274,8 +270,6 @@ export interface IStartupMetrics {
 		 *
 		 * * Happens in the renderer-process
 		 * * Measured with the `willStartWorkbench` and `didStartWorkbench` performance marks.
-		 *
-		 * todo@joh/ramya Not sure if this is useful because this includes too much
 		 */
 		readonly ellapsedWorkbench: number;
 

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,6 @@ export class BulkEditService implements IBulkEditService {`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`// try to find code editor`
`405`		`- // todo@joh, prefer editor that gets edited`
`406`	`405`	`if (!codeEditor) {`
`407`	`406`	`let candidate = this._editorService.activeTextEditorWidget;`
`408`	`407`	`if (isCodeEditor(candidate)) {`