re microsoft#93070. test for command arguments.

rebornix · rebornix · commit 5e9633712174 · 2020-07-13T10:52:57.000-07:00
diff --git a/extensions/vscode-notebook-tests/package.json b/extensions/vscode-notebook-tests/package.json
@@ -31,6 +31,11 @@
       {
         "command": "vscode-notebook-tests.createNewNotebook",
         "title": "Create New Notebook"
+      },
+      {
+        "command": "vscode-notebook-tests.debugAction",
+        "title": "Debug Notebook Test Cell Action",
+        "icon": "$(debug)"
       }
     ],
     "notebookProvider": [
@@ -63,6 +68,15 @@
           "text/custom"
         ]
       }
-    ]
+    ],
+    "menus": {
+      "notebook/cell/title": [
+        {
+          "command": "vscode-notebook-tests.debugAction",
+          "when": "notebookViewType == notebookSmokeTest",
+          "group": "inline@1"
+        }
+      ]
+    }
   }
 }
diff --git a/extensions/vscode-notebook-tests/src/notebookSmokeTestMain.ts b/extensions/vscode-notebook-tests/src/notebookSmokeTestMain.ts
@@ -93,4 +93,15 @@ export function smokeTestActivate(context: vscode.ExtensionContext): any {
 			return;
 		},
 	}));
+
+	context.subscriptions.push(vscode.commands.registerCommand('vscode-notebook-tests.debugAction', async (cell: vscode.NotebookCell) => {
+		if (cell) {
+			const edit = new vscode.WorkspaceEdit();
+			const fullRange = new vscode.Range(0, 0, cell.document.lineCount - 1, cell.document.lineAt(cell.document.lineCount - 1).range.end.character);
+			edit.replace(cell.document.uri, fullRange, 'test');
+			await vscode.workspace.applyEdit(edit);
+		} else {
+			throw new Error('Cell not set correctly');
+		}
+	}));
 }
diff --git a/test/automation/src/notebook.ts b/test/automation/src/notebook.ts
@@ -89,4 +89,8 @@ export class Notebook {
 	async executeActiveCell(): Promise<void> {
 		await this.quickAccess.runCommand('notebook.cell.execute');
 	}
+
+	async executeCellAction(selector: string): Promise<void> {
+		await this.code.waitAndClick(selector);
+	}
 }
diff --git a/test/smoke/src/areas/notebook/notebook.test.ts b/test/smoke/src/areas/notebook/notebook.test.ts
@@ -62,5 +62,13 @@ export function setup() {
 			await app.workbench.notebook.focusOutCellOutput();
 			await app.workbench.notebook.waitForActiveCellEditorContents('code()');
 		});
+
+		it('cell action execution', async function () {
+			const app = this.app as Application;
+			await app.workbench.notebook.openNotebook();
+			await app.workbench.notebook.insertNotebookCell('code');
+			await app.workbench.notebook.executeCellAction('.notebook-editor .monaco-list-row.focused div.monaco-toolbar .codicon-debug');
+			await app.workbench.notebook.waitForActiveCellEditorContents('test');
+		});
 	});
 }

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,11 @@`
`31`	`31`	`{`
`32`	`32`	`"command": "vscode-notebook-tests.createNewNotebook",`
`33`	`33`	`"title": "Create New Notebook"`
	`34`	`+ },`
	`35`	`+ {`
	`36`	`+ "command": "vscode-notebook-tests.debugAction",`
	`37`	`+ "title": "Debug Notebook Test Cell Action",`
	`38`	`+ "icon": "$(debug)"`
`34`	`39`	`}`
`35`	`40`	`],`
`36`	`41`	`"notebookProvider": [`
`@@ -63,6 +68,15 @@`
`63`	`68`	`"text/custom"`
`64`	`69`	`]`
`65`	`70`	`}`
`66`		`- ]`
	`71`	`+ ],`
	`72`	`+ "menus": {`
	`73`	`+ "notebook/cell/title": [`
	`74`	`+ {`
	`75`	`+ "command": "vscode-notebook-tests.debugAction",`
	`76`	`+ "when": "notebookViewType == notebookSmokeTest",`
	`77`	`+ "group": "inline@1"`
	`78`	`+ }`
	`79`	`+ ]`
	`80`	`+ }`
`67`	`81`	`}`
`68`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -89,4 +89,8 @@ export class Notebook {`
`89`	`89`	`async executeActiveCell(): Promise<void> {`
`90`	`90`	`await this.quickAccess.runCommand('notebook.cell.execute');`
`91`	`91`	`}`
	`92`	`+`
	`93`	`+ async executeCellAction(selector: string): Promise<void> {`
	`94`	`+ await this.code.waitAndClick(selector);`
	`95`	`+ }`
`92`	`96`	`}`