focusMode should track whether the cell "should" have focus, not whether it "does" have focus, and so triggering a change event when the value didn't actually change is ok

roblourens · roblourens · commit 5caf5aee6d98 · 2020-06-25T13:46:00.000-05:00
Fix microsoft#100458
diff --git a/src/vs/workbench/contrib/notebook/browser/viewModel/baseCellViewModel.ts b/src/vs/workbench/contrib/notebook/browser/viewModel/baseCellViewModel.ts
@@ -75,12 +75,8 @@ export abstract class BaseCellViewModel extends Disposable {
 		return this._focusMode;
 	}
 	set focusMode(newMode: CellFocusMode) {
-		const changed = this._focusMode !== newMode;
 		this._focusMode = newMode;
-
-		if (changed) {
-			this._onDidChangeState.fire({ focusModeChanged: true });
-		}
+		this._onDidChangeState.fire({ focusModeChanged: true });
 	}
 
 	protected _textEditor?: ICodeEditor;

Original file line number	Diff line number	Diff line change
`@@ -75,12 +75,8 @@ export abstract class BaseCellViewModel extends Disposable {`
`75`	`75`	`return this._focusMode;`
`76`	`76`	`}`
`77`	`77`	`set focusMode(newMode: CellFocusMode) {`
`78`		`- const changed = this._focusMode !== newMode;`
`79`	`78`	`this._focusMode = newMode;`
`80`		`-`
`81`		`- if (changed) {`
`82`		`- this._onDidChangeState.fire({ focusModeChanged: true });`
`83`		`- }`
	`79`	`+ this._onDidChangeState.fire({ focusModeChanged: true });`
`84`	`80`	`}`
`85`	`81`
`86`	`82`	`protected _textEditor?: ICodeEditor;`