Merge pull request microsoft#102149 from Charles-Gagnon/patch-1

joaomoreno · web-flow · commit 5c7e862955ca · 2020-07-21T12:26:57.000+02:00
Only throw error if releaseNotesUrl doesn't exist
diff --git a/src/vs/workbench/contrib/update/browser/update.ts b/src/vs/workbench/contrib/update/browser/update.ts
@@ -55,8 +55,9 @@ export class OpenLatestReleaseNotesInBrowserAction extends Action {
 		if (this.productService.releaseNotesUrl) {
 			const uri = URI.parse(this.productService.releaseNotesUrl);
 			await this.openerService.open(uri);
+		} else {
+			throw new Error(nls.localize('update.noReleaseNotesOnline', "This version of {0} does not have release notes online", this.productService.nameLong));
 		}
-		throw new Error('This version of Visual Studio Code does not have release notes online');
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,9 @@ export class OpenLatestReleaseNotesInBrowserAction extends Action {`
`55`	`55`	`if (this.productService.releaseNotesUrl) {`
`56`	`56`	`const uri = URI.parse(this.productService.releaseNotesUrl);`
`57`	`57`	`await this.openerService.open(uri);`
	`58`	`+ } else {`
	`59`	`+ throw new Error(nls.localize('update.noReleaseNotesOnline', "This version of {0} does not have release notes online", this.productService.nameLong));`
`58`	`60`	`}`
`59`		`- throw new Error('This version of Visual Studio Code does not have release notes online');`
`60`	`61`	`}`
`61`	`62`	`}`
`62`	`63`