Move window border widget into layout service

Tyriar · Tyriar · commit 5c3fdb8d4263 · 2020-08-31T15:41:56.000-07:00
Part of microsoft#104508
diff --git a/src/vs/workbench/browser/layout.ts b/src/vs/workbench/browser/layout.ts
@@ -1616,6 +1616,10 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
 		return this.state.windowBorder;
 	}
 
+	getWindowBorderWidth(): number {
+		return this.state.windowBorder ? 2 : 0;
+	}
+
 	getWindowBorderRadius(): string | undefined {
 		return this.state.windowBorder && isMacintosh ? '5px' : undefined;
 	}
diff --git a/src/vs/workbench/services/hover/browser/hoverWidget.ts b/src/vs/workbench/services/hover/browser/hoverWidget.ts
@@ -143,7 +143,7 @@ export class HoverWidget extends Widget {
 		// Get horizontal alignment and position
 		let targetLeft = this._target.x !== undefined ? this._target.x : Math.min(...targetBounds.map(e => e.left));
 		if (targetLeft + this._hover.containerDomNode.clientWidth >= document.documentElement.clientWidth) {
-			this._x = document.documentElement.clientWidth - (this._workbenchLayoutService.hasWindowBorder() ? 3 : 1);
+			this._x = document.documentElement.clientWidth - this._workbenchLayoutService.getWindowBorderWidth() - 1;
 			this._hover.containerDomNode.classList.add('right-aligned');
 		} else {
 			this._x = targetLeft;
diff --git a/src/vs/workbench/services/layout/browser/layoutService.ts b/src/vs/workbench/services/layout/browser/layoutService.ts
@@ -144,6 +144,11 @@ export interface IWorkbenchLayoutService extends ILayoutService {
 	 */
 	hasWindowBorder(): boolean;
 
+	/**
+	 * Returns the window border width.
+	 */
+	getWindowBorderWidth(): number;
+
 	/**
 	 * Returns the window border radius if any.
 	 */
diff --git a/src/vs/workbench/test/browser/workbenchTestServices.ts b/src/vs/workbench/test/browser/workbenchTestServices.ts
@@ -429,6 +429,7 @@ export class TestLayoutService implements IWorkbenchLayoutService {
 	hasFocus(_part: Parts): boolean { return false; }
 	focusPart(_part: Parts): void { }
 	hasWindowBorder(): boolean { return false; }
+	getWindowBorderWidth(): number { return 0; }
 	getWindowBorderRadius(): string | undefined { return undefined; }
 	isVisible(_part: Parts): boolean { return true; }
 	getDimension(_part: Parts): Dimension { return new Dimension(0, 0); }

Original file line number	Diff line number	Diff line change
`@@ -1616,6 +1616,10 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi`
`1616`	`1616`	`return this.state.windowBorder;`
`1617`	`1617`	`}`
`1618`	`1618`
	`1619`	`+ getWindowBorderWidth(): number {`
	`1620`	`+ return this.state.windowBorder ? 2 : 0;`
	`1621`	`+ }`
	`1622`	`+`
`1619`	`1623`	`getWindowBorderRadius(): string \| undefined {`
`1620`	`1624`	`return this.state.windowBorder && isMacintosh ? '5px' : undefined;`
`1621`	`1625`	`}`