Use array of class names instead of string

mjbvz · mjbvz · commit 5c375ef21cc9 · 2020-06-22T15:24:07.000-07:00
diff --git a/src/vs/editor/common/config/editorOptions.ts b/src/vs/editor/common/config/editorOptions.ts
@@ -1217,26 +1217,28 @@ class EditorClassName extends ComputedEditorOption<EditorOption.editorClassName,
 	}
 
 	public compute(env: IEnvironmentalOptions, options: IComputedEditorOptions, _: string): string {
-		let className = 'monaco-editor';
+		const classNames = ['monaco-editor'];
 		if (options.get(EditorOption.extraEditorClassName)) {
-			className += ' ' + options.get(EditorOption.extraEditorClassName);
+			classNames.push(options.get(EditorOption.extraEditorClassName));
 		}
 		if (env.extraEditorClassName) {
-			className += ' ' + env.extraEditorClassName;
+			classNames.push(env.extraEditorClassName);
 		}
 		if (options.get(EditorOption.mouseStyle) === 'default') {
-			className += ' mouse-default';
+			classNames.push('mouse-default');
 		} else if (options.get(EditorOption.mouseStyle) === 'copy') {
-			className += ' mouse-copy';
+			classNames.push('mouse-copy');
 		}
+
 		if (options.get(EditorOption.showUnused)) {
-			className += ' showUnused';
+			classNames.push('showUnused');
 		}
 
 		if (options.get(EditorOption.showDeprecated)) {
-			className += ' showDeprecated';
+			classNames.push('showDeprecated');
 		}
-		return className;
+
+		return classNames.join(' ');
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1217,26 +1217,28 @@ class EditorClassName extends ComputedEditorOption<EditorOption.editorClassName,`
`1217`	`1217`	`}`
`1218`	`1218`
`1219`	`1219`	`public compute(env: IEnvironmentalOptions, options: IComputedEditorOptions, _: string): string {`
`1220`		`- let className = 'monaco-editor';`
	`1220`	`+ const classNames = ['monaco-editor'];`
`1221`	`1221`	`if (options.get(EditorOption.extraEditorClassName)) {`
`1222`		`- className += ' ' + options.get(EditorOption.extraEditorClassName);`
	`1222`	`+ classNames.push(options.get(EditorOption.extraEditorClassName));`
`1223`	`1223`	`}`
`1224`	`1224`	`if (env.extraEditorClassName) {`
`1225`		`- className += ' ' + env.extraEditorClassName;`
	`1225`	`+ classNames.push(env.extraEditorClassName);`
`1226`	`1226`	`}`
`1227`	`1227`	`if (options.get(EditorOption.mouseStyle) === 'default') {`
`1228`		`- className += ' mouse-default';`
	`1228`	`+ classNames.push('mouse-default');`
`1229`	`1229`	`} else if (options.get(EditorOption.mouseStyle) === 'copy') {`
`1230`		`- className += ' mouse-copy';`
	`1230`	`+ classNames.push('mouse-copy');`
`1231`	`1231`	`}`
	`1232`	`+`
`1232`	`1233`	`if (options.get(EditorOption.showUnused)) {`
`1233`		`- className += ' showUnused';`
	`1234`	`+ classNames.push('showUnused');`
`1234`	`1235`	`}`
`1235`	`1236`
`1236`	`1237`	`if (options.get(EditorOption.showDeprecated)) {`
`1237`		`- className += ' showDeprecated';`
	`1238`	`+ classNames.push('showDeprecated');`
`1238`	`1239`	`}`
`1239`		`- return className;`
	`1240`	`+`
	`1241`	`+ return classNames.join(' ');`
`1240`	`1242`	`}`
`1241`	`1243`	`}`
`1242`	`1244`