Re-render extension editor readme when theme changes

mjbvz · mjbvz · commit 5aee2f0a5ad2 · 2019-09-19T17:02:04.000-07:00
diff --git a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts
@@ -593,9 +593,19 @@ export class ExtensionEditor extends BaseEditor {
 					webviewElement.layoutWebviewOverElement(template.content);
 				}
 			});
-
 			this.contentDisposables.add(toDisposable(removeLayoutParticipant));
 
+			let isDisposed = false;
+			this.contentDisposables.add(toDisposable(() => { isDisposed = true; }));
+
+			this.contentDisposables.add(this.themeService.onThemeChange(async () => {
+				// Render again since syntax highlighting of code blocks may have changed
+				const body = await this.renderMarkdown(cacheResult, template);
+				if (!isDisposed) { // Make sure we weren't disposed of in the meantime
+					webviewElement.html = body;
+				}
+			}));
+
 			this.contentDisposables.add(webviewElement.onDidClickLink(link => {
 				if (!link) {
 					return;
