Strict function fix

mjbvz · mjbvz · commit 59ee3ceeec99 · 2019-12-11T15:40:19.000-08:00
diff --git a/src/vs/workbench/api/browser/mainThreadDiagnostics.ts b/src/vs/workbench/api/browser/mainThreadDiagnostics.ts
@@ -33,7 +33,7 @@ export class MainThreadDiagnostics implements MainThreadDiagnosticsShape {
 		this._activeOwners.clear();
 	}
 
-	private _forwardMarkers(resources: URI[]): void {
+	private _forwardMarkers(resources: readonly URI[]): void {
 		const data: [UriComponents, IMarkerData[]][] = [];
 		for (const resource of resources) {
 			data.push([
diff --git a/src/vs/workbench/services/keybinding/browser/keymapService.ts b/src/vs/workbench/services/keybinding/browser/keymapService.ts
@@ -349,7 +349,7 @@ export class BrowserKeyboardMapperFactoryBase {
 			// The value is empty when the key is not a printable character, we skip validation.
 			if (keyboardEvent.ctrlKey || keyboardEvent.metaKey) {
 				setTimeout(() => {
-					this._getBrowserKeyMapping().then((keymap: IKeyboardMapping) => {
+					this._getBrowserKeyMapping().then((keymap: IRawMixedKeyboardMapping | null) => {
 						if (this.isKeyMappingActive(keymap)) {
 							return;
 						}
diff --git a/src/vs/workbench/services/preferences/browser/preferencesService.ts b/src/vs/workbench/services/preferences/browser/preferencesService.ts
@@ -314,9 +314,9 @@ export class PreferencesService extends Disposable implements IPreferencesServic
 	configureSettingsForLanguage(language: string): void {
 		this.openGlobalSettings(true)
 			.then(editor => this.createPreferencesEditorModel(this.userSettingsResource)
-				.then((settingsModel: IPreferencesEditorModel<ISetting>) => {
+				.then((settingsModel: IPreferencesEditorModel<ISetting> | null) => {
 					const codeEditor = editor ? getCodeEditor(editor.getControl()) : null;
-					if (codeEditor) {
+					if (codeEditor && settingsModel) {
 						this.addLanguageOverrideEntry(language, settingsModel, codeEditor)
 							.then(position => {
 								if (codeEditor && position) {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ export class MainThreadDiagnostics implements MainThreadDiagnosticsShape {`
`33`	`33`	`this._activeOwners.clear();`
`34`	`34`	`}`
`35`	`35`
`36`		`- private _forwardMarkers(resources: URI[]): void {`
	`36`	`+ private _forwardMarkers(resources: readonly URI[]): void {`
`37`	`37`	`const data: [UriComponents, IMarkerData[]][] = [];`
`38`	`38`	`for (const resource of resources) {`
`39`	`39`	`data.push([`
Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,7 @@ export class BrowserKeyboardMapperFactoryBase {`
`349`	`349`	`// The value is empty when the key is not a printable character, we skip validation.`
`350`	`350`	`if (keyboardEvent.ctrlKey \|\| keyboardEvent.metaKey) {`
`351`	`351`	`setTimeout(() => {`
`352`		`- this._getBrowserKeyMapping().then((keymap: IKeyboardMapping) => {`
	`352`	`+ this._getBrowserKeyMapping().then((keymap: IRawMixedKeyboardMapping \| null) => {`
`353`	`353`	`if (this.isKeyMappingActive(keymap)) {`
`354`	`354`	`return;`
`355`	`355`	`}`