fix problem with getConfigurationValue, microsoft#10583

jrieken · jrieken · commit 5834bb372c8d · 2016-11-04T17:18:58.000+01:00
diff --git a/src/vs/platform/configuration/common/configuration.ts b/src/vs/platform/configuration/common/configuration.ts
@@ -65,7 +65,7 @@ export function getConfigurationValue<T>(config: any, settingPath: string, defau
 		let current = config;
 		for (let i = 0; i < path.length; i++) {
 			current = current[path[i]];
-			if (!current) {
+			if (typeof current === 'undefined') {
 				return undefined;
 			}
 		}
@@ -76,4 +76,4 @@ export function getConfigurationValue<T>(config: any, settingPath: string, defau
 	const result = accessSetting(config, path);
 
 	return typeof result === 'undefined' ? defaultValue : result;
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ export function getConfigurationValue<T>(config: any, settingPath: string, defau`
`65`	`65`	`let current = config;`
`66`	`66`	`for (let i = 0; i < path.length; i++) {`
`67`	`67`	`current = current[path[i]];`
`68`		`- if (!current) {`
	`68`	`+ if (typeof current === 'undefined') {`
`69`	`69`	`return undefined;`
`70`	`70`	`}`
`71`	`71`	`}`
`@@ -76,4 +76,4 @@ export function getConfigurationValue<T>(config: any, settingPath: string, defau`
`76`	`76`	`const result = accessSetting(config, path);`
`77`	`77`
`78`	`78`	`return typeof result === 'undefined' ? defaultValue : result;`
`79`		`-}`
	`79`	`+}`