Only update visibilities when visible (microsoft#84125)

chrmarti · chrmarti · commit 57ddcfd7923f · 2019-11-12T14:40:18.000+01:00
diff --git a/src/vs/workbench/browser/parts/quickinput/quickInput.ts b/src/vs/workbench/browser/parts/quickinput/quickInput.ts
@@ -702,11 +702,11 @@ class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPi
 	}
 
 	protected update() {
-		this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title || !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true, message: !!this.validationMessage } : { title: !!this.title || !!this.step, inputBox: true, visibleCount: true, list: true, message: !!this.validationMessage, customButton: this.customButton, ok: this.ok });
-		super.update();
 		if (!this.visible) {
 			return;
 		}
+		this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title || !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true, message: !!this.validationMessage } : { title: !!this.title || !!this.step, inputBox: true, visibleCount: true, list: true, message: !!this.validationMessage, customButton: this.customButton, ok: this.ok });
+		super.update();
 		if (this.ui.inputBox.value !== this.value) {
 			this.ui.inputBox.value = this.value;
 		}
@@ -860,11 +860,11 @@ class InputBox extends QuickInput implements IInputBox {
 	}
 
 	protected update() {
-		this.ui.setVisibilities({ title: !!this.title || !!this.step, inputBox: true, message: true });
-		super.update();
 		if (!this.visible) {
 			return;
 		}
+		this.ui.setVisibilities({ title: !!this.title || !!this.step, inputBox: true, message: true });
+		super.update();
 		if (this.ui.inputBox.value !== this.value) {
 			this.ui.inputBox.value = this.value;
 		}

Original file line number	Diff line number	Diff line change
`@@ -702,11 +702,11 @@ class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPi`
`702`	`702`	`}`
`703`	`703`
`704`	`704`	`protected update() {`
`705`		`- this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title \|\| !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true, message: !!this.validationMessage } : { title: !!this.title \|\| !!this.step, inputBox: true, visibleCount: true, list: true, message: !!this.validationMessage, customButton: this.customButton, ok: this.ok });`
`706`		`- super.update();`
`707`	`705`	`if (!this.visible) {`
`708`	`706`	`return;`
`709`	`707`	`}`
	`708`	`+ this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title \|\| !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true, message: !!this.validationMessage } : { title: !!this.title \|\| !!this.step, inputBox: true, visibleCount: true, list: true, message: !!this.validationMessage, customButton: this.customButton, ok: this.ok });`
	`709`	`+ super.update();`
`710`	`710`	`if (this.ui.inputBox.value !== this.value) {`
`711`	`711`	`this.ui.inputBox.value = this.value;`
`712`	`712`	`}`
`@@ -860,11 +860,11 @@ class InputBox extends QuickInput implements IInputBox {`
`860`	`860`	`}`
`861`	`861`
`862`	`862`	`protected update() {`
`863`		`- this.ui.setVisibilities({ title: !!this.title \|\| !!this.step, inputBox: true, message: true });`
`864`		`- super.update();`
`865`	`863`	`if (!this.visible) {`
`866`	`864`	`return;`
`867`	`865`	`}`
	`866`	`+ this.ui.setVisibilities({ title: !!this.title \|\| !!this.step, inputBox: true, message: true });`
	`867`	`+ super.update();`
`868`	`868`	`if (this.ui.inputBox.value !== this.value) {`
`869`	`869`	`this.ui.inputBox.value = this.value;`
`870`	`870`	`}`