update extensions aria label to contain version and publisher display name

isidorn · isidorn · commit 55e09d6bf842 · 2020-07-28T19:16:02.000+02:00
fixes microsoft#102224
diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsViewer.ts b/src/vs/workbench/contrib/extensions/browser/extensionsViewer.ts
@@ -271,7 +271,8 @@ export class ExtensionsTree extends WorkbenchAsyncDataTree<IExtensionData, IExte
 				overrideStyles,
 				accessibilityProvider: <IListAccessibilityProvider<IExtensionData>>{
 					getAriaLabel(extensionData: IExtensionData): string {
-						return localize('extension-arialabel', "{0}. Press enter for extension details.", extensionData.extension.displayName);
+						const extension = extensionData.extension;
+						return localize('extension-arialabel', "{0}, {1}, {2}, press enter for extension details.", extension.displayName, extension.version, extension.publisherDisplayName);
 					},
 					getWidgetAriaLabel(): string {
 						return localize('extensions', "Extensions");
diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsViews.ts b/src/vs/workbench/contrib/extensions/browser/extensionsViews.ts
@@ -139,7 +139,7 @@ export class ExtensionsListView extends ViewPane {
 			horizontalScrolling: false,
 			accessibilityProvider: <IListAccessibilityProvider<IExtension | null>>{
 				getAriaLabel(extension: IExtension | null): string {
-					return extension ? localize('extension-arialabel', "{0}. Press enter for extension details.", extension.displayName) : '';
+					return extension ? localize('extension-arialabel', "{0}, {1}, {2}, press enter for extension details.", extension.displayName, extension.version, extension.publisherDisplayName) : '';
 				},
 				getWidgetAriaLabel(): string {
 					return localize('extensions', "Extensions");
diff --git a/test/automation/src/extensions.ts b/test/automation/src/extensions.ts
@@ -34,9 +34,9 @@ export class Extensions extends Viewlet {
 		await this.code.waitForTypeInEditor(SEARCH_BOX, `@id:${id}`);
 	}
 
-	async installExtension(id: string, name: string): Promise<void> {
+	async installExtension(id: string, name: string, version: string, publisherDisplayName: string): Promise<void> {
 		await this.searchForExtension(id);
-		const ariaLabel = `${name}. Press enter for extension details.`;
+		const ariaLabel = `${name}, ${version}, ${publisherDisplayName}, press enter for extension details.`;
 		await this.code.waitAndClick(`div.extensions-viewlet[id="workbench.view.extensions"] .monaco-list-row[aria-label="${ariaLabel}"] .extension-list-item li[class='action-item'] .extension-action.install`);
 		await this.code.waitForElement(`.extension-editor .monaco-action-bar .action-item:not(.disabled) .extension-action.uninstall`);
 	}

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,9 @@ export class Extensions extends Viewlet {`
`34`	`34`	await this.code.waitForTypeInEditor(SEARCH_BOX, `@id:${id}`);
`35`	`35`	`}`
`36`	`36`
`37`		`- async installExtension(id: string, name: string): Promise<void> {`
	`37`	`+ async installExtension(id: string, name: string, version: string, publisherDisplayName: string): Promise<void> {`
`38`	`38`	`await this.searchForExtension(id);`
`39`		- const ariaLabel = `${name}. Press enter for extension details.`;
	`39`	+ const ariaLabel = `${name}, ${version}, ${publisherDisplayName}, press enter for extension details.`;
`40`	`40`	await this.code.waitAndClick(`div.extensions-viewlet[id="workbench.view.extensions"] .monaco-list-row[aria-label="${ariaLabel}"] .extension-list-item li[class='action-item'] .extension-action.install`);
`41`	`41`	await this.code.waitForElement(`.extension-editor .monaco-action-bar .action-item:not(.disabled) .extension-action.uninstall`);
`42`	`42`	`}`