Skip to content

Commit 54782e5

Browse files
author
Benjamin Pasero
committed
some tslint in platform
1 parent 19ed5bf commit 54782e5

9 files changed

Lines changed: 14 additions & 84 deletions

File tree

‎src/vs/platform/files/common/files.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,11 @@
44
*--------------------------------------------------------------------------------------------*/
55
'use strict';
66

7-
import assert = require('vs/base/common/assert');
87
import winjs = require('vs/base/common/winjs.base');
98
import paths = require('vs/base/common/paths');
109
import URI from 'vs/base/common/uri';
11-
import nls = require('vs/nls');
12-
import encoding = require('vs/base/common/bits/encoding');
13-
import types = require('vs/base/common/types');
14-
import strings = require('vs/base/common/strings');
1510
import glob = require('vs/base/common/glob');
16-
import arrays = require('vs/base/common/arrays');
1711
import events = require('vs/base/common/events');
18-
import mimes = require('vs/base/common/mime');
1912
import {createDecorator, ServiceIdentifier} from 'vs/platform/instantiation/common/instantiation';
2013

2114
export var IFileService = createDecorator<IFileService>('fileService');

‎src/vs/platform/instantiation/test/common/instantiationService.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {SyncDescriptor, createSyncDescriptor} from 'vs/platform/instantiation/co
1414

1515
export class Target1 {
1616

17-
constructor(private platformServices:services.IPlatformServices) {
17+
constructor(private platformServices) {
1818
assert.ok(!!platformServices.editorService);
1919
}
2020

@@ -30,7 +30,7 @@ export class Target1 {
3030

3131
export class Target2 {
3232

33-
constructor(private platformServices:services.IPlatformServices, private far:boolean) {
33+
constructor(private platformServices, private far:boolean) {
3434
assert.ok(!!platformServices.editorService);
3535
}
3636

@@ -48,21 +48,21 @@ export class Target2 {
4848
}
4949

5050
class Target3 {
51-
constructor(private platformServices:services.IPlatformServices) {
51+
constructor(private platformServices) {
5252
assert.ok(!!platformServices.editorService);
5353
assert.equal(platformServices['far'], 1234);
5454
}
5555
}
5656

5757
class Target4 {
58-
constructor(private platformServices:services.IPlatformServices) {
58+
constructor(private platformServices) {
5959
assert.equal(platformServices.editorService, 1234);
6060
}
6161
}
6262

6363
export class EvilTarget1 {
6464

65-
constructor(private platformServices:services.IPlatformServices) {
65+
constructor(private platformServices) {
6666
platformServices.editorService = null;
6767
}
6868
}

‎src/vs/platform/lifecycle/common/baseLifecycleService.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
*--------------------------------------------------------------------------------------------*/
55
'use strict';
66

7-
import arrays = require('vs/base/common/arrays');
8-
import winjs = require('vs/base/common/winjs.base');
97
import Event, {Emitter} from 'vs/base/common/event';
108

119
import {ILifecycleService, IBeforeShutdownParticipant} from './lifecycle';

‎src/vs/platform/lifecycle/common/lifecycle.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
'use strict';
66

77
import winjs = require('vs/base/common/winjs.base');
8-
import Event, {Emitter} from 'vs/base/common/event';
8+
import Event from 'vs/base/common/event';
99
import {createDecorator, ServiceIdentifier} from 'vs/platform/instantiation/common/instantiation';
1010

1111
export var ILifecycleService = createDecorator<ILifecycleService>('lifecycleService');

‎src/vs/platform/lifecycle/common/nullLifecycleService.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ class NullLifecycleService implements ILifecycleService {
1212

1313
public serviceId = ILifecycleService;
1414

15-
private _onBeforeShutdown: Emitter<any> = new Emitter<any>();
1615
private _onShutdown: Emitter<any> = new Emitter<any>();
1716

1817
public addBeforeShutdownParticipant(p: IBeforeShutdownParticipant): void {

‎src/vs/platform/platform.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,13 @@ export class BaseRegistry<T> {
7070
this.instantiationService = service;
7171

7272
while(this.toBeInstantiated.length > 0) {
73-
var entry = this.toBeInstantiated.shift();
73+
let entry = this.toBeInstantiated.shift();
7474
this.instantiate(entry);
7575
}
7676
}
7777

7878
private instantiate(ctor:IConstructorSignature0<T> | INewConstructorSignature0<T>):void {
79-
var instance = this.instantiationService.createInstance(ctor);
79+
let instance = this.instantiationService.createInstance(ctor);
8080
this.instances.push(instance);
8181
}
8282

‎src/vs/platform/search/common/search.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,9 @@ export class LineMatch implements ILineMatch {
9292
export interface ISearchConfiguration extends IFilesConfiguration {
9393
search: {
9494
exclude: glob.IExpression;
95-
},
95+
};
96+
9697
filePicker: {
9798
alternateFileNameMatching: boolean;
98-
}
99+
};
99100
}

‎src/vs/platform/services.ts‎

Lines changed: 1 addition & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -4,70 +4,9 @@
44
*--------------------------------------------------------------------------------------------*/
55
'use strict';
66

7-
import winjs = require('vs/base/common/winjs.base');
8-
import Severity from 'vs/base/common/severity';
9-
import Async = require('vs/base/common/async');
10-
import Strings = require('vs/base/common/strings');
11-
import Network = require('vs/base/common/network');
12-
import URI from 'vs/base/common/uri';
13-
import Glob = require('vs/base/common/glob');
14-
import Paths = require('vs/base/common/paths');
15-
import EventEmitter = require('vs/base/common/eventEmitter');
16-
import Timer = require('vs/base/common/timer');
17-
import objects = require('vs/base/common/objects');
18-
import Actions = require('vs/base/common/actions');
19-
import ActionBar = require('vs/base/browser/ui/actionbar/actionbar');
20-
import Lifecycle = require('vs/base/common/lifecycle');
21-
import hash = require('vs/base/common/hash');
22-
import errors = require('vs/base/common/errors');
23-
import types = require('vs/base/common/types');
24-
25-
import http = require('vs/base/common/http');
26-
import events = require('vs/base/common/events');
27-
import {IConfigurationService} from 'vs/platform/configuration/common/configuration';
28-
import {IContextViewService, IContextMenuService} from 'vs/platform/contextview/browser/contextView';
29-
import {IEditorService} from 'vs/platform/editor/common/editor';
30-
import {IEventService} from 'vs/platform/event/common/event';
31-
import {IFileService} from 'vs/platform/files/common/files';
327
import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
33-
import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
34-
import {ILifecycleService} from 'vs/platform/lifecycle/common/lifecycle';
35-
import {IMarkerService} from 'vs/platform/markers/common/markers';
36-
import {IMessageService} from 'vs/platform/message/common/message';
37-
import {IProgressService} from 'vs/platform/progress/common/progress';
38-
import {IStorageService} from 'vs/platform/storage/common/storage';
39-
import {IRequestService} from 'vs/platform/request/common/request';
40-
import {ISearchService} from 'vs/platform/search/common/search';
41-
import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
42-
import {IThreadService} from 'vs/platform/thread/common/thread';
43-
import {IPluginService} from 'vs/platform/plugins/common/plugins';
44-
import {IWorkspaceContextService} from 'vs/platform/workspace/common/workspace';
458

469
export interface IServicesContext {
4710
[serviceName: string]: any;
4811
instantiationService: IInstantiationService;
49-
}
50-
51-
export interface IPlatformServices extends IServicesContext {
52-
threadService:IThreadService;
53-
pluginService: IPluginService;
54-
instantiationService:IInstantiationService;
55-
lifecycleService: ILifecycleService;
56-
messageService:IMessageService;
57-
markerService: IMarkerService;
58-
editorService:IEditorService;
59-
requestService:IRequestService;
60-
keybindingService:IKeybindingService;
61-
contextService:IWorkspaceContextService;
62-
contextViewService:IContextViewService;
63-
contextMenuService:IContextMenuService;
64-
telemetryService:ITelemetryService;
65-
eventService:IEventService;
66-
storageService:IStorageService;
67-
searchService:ISearchService;
68-
configurationService:IConfigurationService;
69-
progressService:IProgressService;
70-
fileService:IFileService;
71-
}
72-
73-
12+
}

‎src/vs/platform/workspace/common/workspace.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,11 @@ export interface IEnvironment {
138138
aiConfig: {
139139
key: string;
140140
asimovKey: string;
141-
},
141+
};
142142

143143
sendASmile: {
144144
submitUrl: string,
145145
reportIssueUrl: string,
146146
requestFeatureUrl: string
147-
}
147+
};
148148
}

0 commit comments

Comments
 (0)