don't throw with invalid regexes, microsoft#51109

jrieken · jrieken · commit 54298e286140 · 2018-06-05T15:51:43.000+02:00
diff --git a/src/vs/platform/contextkey/common/contextkey.ts b/src/vs/platform/contextkey/common/contextkey.ts
@@ -401,7 +401,10 @@ export class ContextKeyRegexExpr implements ContextKeyExpr {
 	}
 
 	public serialize(): string {
-		return `${this.key} =~ /${this.regexp ? this.regexp.source : '<invalid>'}/${this.regexp.ignoreCase ? 'i' : ''}`;
+		const value = this.regexp
+			? `/${this.regexp.source}/${this.regexp.ignoreCase ? 'i' : ''}`
+			: '/invalid/';
+		return `${this.key} =~ ${value}`;
 	}
 
 	public keys(): string[] {

Original file line number	Diff line number	Diff line change
`@@ -401,7 +401,10 @@ export class ContextKeyRegexExpr implements ContextKeyExpr {`
`401`	`401`	`}`
`402`	`402`
`403`	`403`	`public serialize(): string {`
`404`		- return `${this.key} =~ /${this.regexp ? this.regexp.source : '<invalid>'}/${this.regexp.ignoreCase ? 'i' : ''}`;
	`404`	`+ const value = this.regexp`
	`405`	+ ? `/${this.regexp.source}/${this.regexp.ignoreCase ? 'i' : ''}`
	`406`	`+ : '/invalid/';`
	`407`	+ return `${this.key} =~ ${value}`;
`405`	`408`	`}`
`406`	`409`
`407`	`410`	`public keys(): string[] {`