Add additional no unused checks for php extension

mjbvz · mjbvz · commit 52f45af7f092 · 2017-11-07T11:22:07.000-08:00
diff --git a/extensions/php/src/features/completionItemProvider.ts b/extensions/php/src/features/completionItemProvider.ts
@@ -12,7 +12,7 @@ export default class PHPCompletionItemProvider implements CompletionItemProvider
 
 	public triggerCharacters = ['.', ':', '$'];
 
-	public provideCompletionItems(document: TextDocument, position: Position, token: CancellationToken): Promise<CompletionItem[]> {
+	public provideCompletionItems(document: TextDocument, position: Position, _token: CancellationToken): Promise<CompletionItem[]> {
 		let result: CompletionItem[] = [];
 
 		let shouldProvideCompletionItems = workspace.getConfiguration('php').get<boolean>('suggest.basic', true);
diff --git a/extensions/php/src/features/hoverProvider.ts b/extensions/php/src/features/hoverProvider.ts
@@ -11,15 +11,15 @@ import { textToMarkedString } from './utils/markedTextUtil';
 
 export default class PHPHoverProvider implements HoverProvider {
 
-	public provideHover(document: TextDocument, position: Position, token: CancellationToken): Hover | undefined {
+	public provideHover(document: TextDocument, position: Position, _token: CancellationToken): Hover | undefined {
 		let enable = workspace.getConfiguration('php').get<boolean>('suggest.basic', true);
 		if (!enable) {
-			return;
+			return undefined;
 		}
 
 		let wordRange = document.getWordRangeAtPosition(position);
 		if (!wordRange) {
-			return;
+			return undefined;
 		}
 
 		let name = document.getText(wordRange);
@@ -30,5 +30,7 @@ export default class PHPHoverProvider implements HoverProvider {
 			let contents: MarkedString[] = [textToMarkedString(entry.description), { language: 'php', value: signature }];
 			return new Hover(contents, wordRange);
 		}
+
+		return undefined;
 	}
 }
diff --git a/extensions/php/src/features/signatureHelpProvider.ts b/extensions/php/src/features/signatureHelpProvider.ts
@@ -69,7 +69,7 @@ class BackwardIterator {
 
 export default class PHPSignatureHelpProvider implements SignatureHelpProvider {
 
-	public provideSignatureHelp(document: TextDocument, position: Position, token: CancellationToken): Promise<SignatureHelp> | null {
+	public provideSignatureHelp(document: TextDocument, position: Position, _token: CancellationToken): Promise<SignatureHelp> | null {
 		let enable = workspace.getConfiguration('php').get<boolean>('suggest.basic', true);
 		if (!enable) {
 			return null;
diff --git a/extensions/php/src/features/utils/async.ts b/extensions/php/src/features/utils/async.ts
@@ -53,7 +53,7 @@ export class Throttler<T> {
 					return result;
 				};
 
-				this.queuedPromise = new Promise<T>((resolve, reject) => {
+				this.queuedPromise = new Promise<T>((resolve) => {
 					this.activePromise!.then(onComplete, onComplete).then(resolve);
 				});
 			}
@@ -121,7 +121,7 @@ export class Delayer<T> {
 		this.cancelTimeout();
 
 		if (!this.completionPromise) {
-			this.completionPromise = new Promise<T>((resolve, reject) => {
+			this.completionPromise = new Promise<T>((resolve) => {
 				this.onResolve = resolve;
 			}).then(() => {
 				this.completionPromise = null;
diff --git a/extensions/php/src/features/validationProvider.ts b/extensions/php/src/features/validationProvider.ts
@@ -224,7 +224,7 @@ export default class PHPValidationProvider {
 	}
 
 	private doValidate(textDocument: vscode.TextDocument): Promise<void> {
-		return new Promise<void>((resolve, reject) => {
+		return new Promise<void>((resolve) => {
 			let executable = this.executable || 'php';
 			let decoder = new LineDecoder();
 			let diagnostics: vscode.Diagnostic[] = [];
diff --git a/extensions/php/tsconfig.json b/extensions/php/tsconfig.json
@@ -6,6 +6,10 @@
 		],
 		"module": "commonjs",
 		"outDir": "./out",
+		"noImplicitAny": true,
+		"noImplicitReturns": true,
+		"noUnusedLocals": true,
+		"noUnusedParameters": true,
 		"strict": true
 	},
 	"include": [

Original file line number	Diff line number	Diff line change
`@@ -11,15 +11,15 @@ import { textToMarkedString } from './utils/markedTextUtil';`
`11`	`11`
`12`	`12`	`export default class PHPHoverProvider implements HoverProvider {`
`13`	`13`
`14`		`- public provideHover(document: TextDocument, position: Position, token: CancellationToken): Hover \| undefined {`
	`14`	`+ public provideHover(document: TextDocument, position: Position, _token: CancellationToken): Hover \| undefined {`
`15`	`15`	`let enable = workspace.getConfiguration('php').get<boolean>('suggest.basic', true);`
`16`	`16`	`if (!enable) {`
`17`		`- return;`
	`17`	`+ return undefined;`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`let wordRange = document.getWordRangeAtPosition(position);`
`21`	`21`	`if (!wordRange) {`
`22`		`- return;`
	`22`	`+ return undefined;`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`let name = document.getText(wordRange);`
`@@ -30,5 +30,7 @@ export default class PHPHoverProvider implements HoverProvider {`
`30`	`30`	`let contents: MarkedString[] = [textToMarkedString(entry.description), { language: 'php', value: signature }];`
`31`	`31`	`return new Hover(contents, wordRange);`
`32`	`32`	`}`
	`33`	`+`
	`34`	`+ return undefined;`
`33`	`35`	`}`
`34`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ export default class PHPValidationProvider {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`private doValidate(textDocument: vscode.TextDocument): Promise<void> {`
`227`		`- return new Promise<void>((resolve, reject) => {`
	`227`	`+ return new Promise<void>((resolve) => {`
`228`	`228`	`let executable = this.executable \|\| 'php';`
`229`	`229`	`let decoder = new LineDecoder();`
`230`	`230`	`let diagnostics: vscode.Diagnostic[] = [];`