Make sure we hide the webview overlay when it is not in use

Matt Bierner · Matt Bierner · commit 52b6e7c4f584 · 2019-07-17T18:53:02.000-07:00
diff --git a/src/vs/workbench/contrib/webview/browser/webviewService.ts b/src/vs/workbench/contrib/webview/browser/webviewService.ts
@@ -81,9 +81,8 @@ class DynamicWebviewEditorOverlay extends Disposable implements WebviewEditorOve
 		}
 
 		this._owner = undefined;
-		if (this.options.retainContextWhenHidden) {
-			this.container.style.visibility = 'hidden';
-		} else {
+		this.container.style.visibility = 'hidden';
+		if (!this.options.retainContextWhenHidden) {
 			this._webview.clear();
 			this._webviewEvents.clear();
 		}

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,8 @@ class DynamicWebviewEditorOverlay extends Disposable implements WebviewEditorOve`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`this._owner = undefined;`
`84`		`- if (this.options.retainContextWhenHidden) {`
`85`		`- this.container.style.visibility = 'hidden';`
`86`		`- } else {`
	`84`	`+ this.container.style.visibility = 'hidden';`
	`85`	`+ if (!this.options.retainContextWhenHidden) {`
`87`	`86`	`this._webview.clear();`
`88`	`87`	`this._webviewEvents.clear();`
`89`	`88`	`}`