Use correct $name for onDidDisposeWebviewPanel event

mjbvz · mjbvz · commit 52a75ecf2333 · 2018-04-18T11:32:29.000-07:00
Fixes microsoft#48127
diff --git a/src/vs/workbench/api/electron-browser/mainThreadWebview.ts b/src/vs/workbench/api/electron-browser/mainThreadWebview.ts
@@ -177,7 +177,7 @@ export class MainThreadWebviews implements MainThreadWebviewsShape, WebviewReviv
 			onDidClickLink: uri => this.onDidClickLink(handle, uri),
 			onMessage: message => this._proxy.$onMessage(handle, message),
 			onDispose: () => {
-				this._proxy.onDidDisposeWebviewPanel(handle).then(() => {
+				this._proxy.$onDidDisposeWebviewPanel(handle).then(() => {
 					this._webviews.delete(handle);
 				});
 			}
diff --git a/src/vs/workbench/api/node/extHost.protocol.ts b/src/vs/workbench/api/node/extHost.protocol.ts
@@ -364,7 +364,7 @@ export interface MainThreadWebviewsShape extends IDisposable {
 export interface ExtHostWebviewsShape {
 	$onMessage(handle: WebviewPanelHandle, message: any): void;
 	$onDidChangeWebviewPanelViewState(handle: WebviewPanelHandle, active: boolean, position: EditorPosition): void;
-	onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void>;
+	$onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void>;
 	$deserializeWebviewPanel(newWebviewHandle: WebviewPanelHandle, viewType: string, title: string, state: any, position: EditorPosition, options: vscode.WebviewOptions): Thenable<void>;
 	$serializeWebviewPanel(webviewHandle: WebviewPanelHandle): Thenable<any>;
 }
diff --git a/src/vs/workbench/api/node/extHostWebview.ts b/src/vs/workbench/api/node/extHostWebview.ts
@@ -254,7 +254,7 @@ export class ExtHostWebviews implements ExtHostWebviewsShape {
 		}
 	}
 
-	onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void> {
+	$onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void> {
 		const panel = this.getWebviewPanel(handle);
 		if (panel) {
 			panel.dispose();

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ export class MainThreadWebviews implements MainThreadWebviewsShape, WebviewReviv`
`177`	`177`	`onDidClickLink: uri => this.onDidClickLink(handle, uri),`
`178`	`178`	`onMessage: message => this._proxy.$onMessage(handle, message),`
`179`	`179`	`onDispose: () => {`
`180`		`- this._proxy.onDidDisposeWebviewPanel(handle).then(() => {`
	`180`	`+ this._proxy.$onDidDisposeWebviewPanel(handle).then(() => {`
`181`	`181`	`this._webviews.delete(handle);`
`182`	`182`	`});`
`183`	`183`	`}`
Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ export interface MainThreadWebviewsShape extends IDisposable {`
`364`	`364`	`export interface ExtHostWebviewsShape {`
`365`	`365`	`$onMessage(handle: WebviewPanelHandle, message: any): void;`
`366`	`366`	`$onDidChangeWebviewPanelViewState(handle: WebviewPanelHandle, active: boolean, position: EditorPosition): void;`
`367`		`- onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void>;`
	`367`	`+ $onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void>;`
`368`	`368`	`$deserializeWebviewPanel(newWebviewHandle: WebviewPanelHandle, viewType: string, title: string, state: any, position: EditorPosition, options: vscode.WebviewOptions): Thenable<void>;`
`369`	`369`	`$serializeWebviewPanel(webviewHandle: WebviewPanelHandle): Thenable<any>;`
`370`	`370`	`}`
Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ export class ExtHostWebviews implements ExtHostWebviewsShape {`
`254`	`254`	`}`
`255`	`255`	`}`
`256`	`256`
`257`		`- onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void> {`
	`257`	`+ $onDidDisposeWebviewPanel(handle: WebviewPanelHandle): Thenable<void> {`
`258`	`258`	`const panel = this.getWebviewPanel(handle);`
`259`	`259`	`if (panel) {`
`260`	`260`	`panel.dispose();`