Skip to content

Commit 52690ed

Browse files
committed
Re-enable integrated term windows shell args
Fixes microsoft#8429
1 parent 74d0241 commit 52690ed

3 files changed

Lines changed: 11 additions & 1 deletion

File tree

src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,14 @@ configurationRegistry.registerConfiguration({
6161
'type': 'string',
6262
'default': TERMINAL_DEFAULT_SHELL_WINDOWS
6363
},
64+
'terminal.integrated.shellArgs.windows': {
65+
'description': nls.localize('terminal.integrated.shellArgs.windows', "The command line arguments to use when on the Windows terminal."),
66+
'type': 'array',
67+
'items': {
68+
'type': 'string'
69+
},
70+
'default': []
71+
},
6472
'terminal.integrated.fontFamily': {
6573
'description': nls.localize('terminal.integrated.fontFamily', "Controls the font family of the terminal, this defaults to editor.fontFamily's value."),
6674
'type': 'string'

src/vs/workbench/parts/terminal/electron-browser/terminal.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ export interface ITerminalConfiguration {
3939
},
4040
shellArgs: {
4141
linux: string[],
42-
osx: string[]
42+
osx: string[],
43+
windows: string[]
4344
},
4445
cursorBlinking: boolean,
4546
fontFamily: string,

src/vs/workbench/parts/terminal/electron-browser/terminalConfigHelper.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ export class TerminalConfigHelper {
160160
};
161161
if (this._platform === Platform.Windows) {
162162
shell.executable = config.terminal.integrated.shell.windows;
163+
shell.args = config.terminal.integrated.shellArgs.windows;
163164
} else if (this._platform === Platform.Mac) {
164165
shell.executable = config.terminal.integrated.shell.osx;
165166
shell.args = config.terminal.integrated.shellArgs.osx;

0 commit comments

Comments
 (0)