do not use arguments

sandy081 · sandy081 · commit 50ec968a0ad2 · 2019-09-26T13:52:29.000+02:00
diff --git a/src/vs/platform/log/node/spdlogService.ts b/src/vs/platform/log/node/spdlogService.ts
@@ -86,47 +86,46 @@ export class SpdLogService extends AbstractLogService implements ILogService {
 		}
 	}
 
-	trace(): void {
+	trace(message: string, ...args: any[]): void {
 		if (this.getLevel() <= LogLevel.Trace) {
-			this._log(LogLevel.Trace, this.format(arguments));
+			this._log(LogLevel.Trace, this.format([message, ...args]));
 		}
 	}
 
-	debug(): void {
+	debug(message: string, ...args: any[]): void {
 		if (this.getLevel() <= LogLevel.Debug) {
-			this._log(LogLevel.Debug, this.format(arguments));
+			this._log(LogLevel.Debug, this.format([message, ...args]));
 		}
 	}
 
-	info(): void {
+	info(message: string, ...args: any[]): void {
 		if (this.getLevel() <= LogLevel.Info) {
-			this._log(LogLevel.Info, this.format(arguments));
+			this._log(LogLevel.Info, this.format([message, ...args]));
 		}
 	}
 
-	warn(): void {
+	warn(message: string, ...args: any[]): void {
 		if (this.getLevel() <= LogLevel.Warning) {
-			this._log(LogLevel.Warning, this.format(arguments));
+			this._log(LogLevel.Warning, this.format([message, ...args]));
 		}
 	}
 
-	error(): void {
+	error(message: string | Error, ...args: any[]): void {
 		if (this.getLevel() <= LogLevel.Error) {
-			const arg = arguments[0];
 
-			if (arg instanceof Error) {
+			if (message instanceof Error) {
 				const array = Array.prototype.slice.call(arguments) as any[];
-				array[0] = arg.stack;
+				array[0] = message.stack;
 				this._log(LogLevel.Error, this.format(array));
 			} else {
-				this._log(LogLevel.Error, this.format(arguments));
+				this._log(LogLevel.Error, this.format([message, ...args]));
 			}
 		}
 	}
 
-	critical(): void {
+	critical(message: string | Error, ...args: any[]): void {
 		if (this.getLevel() <= LogLevel.Critical) {
-			this._log(LogLevel.Critical, this.format(arguments));
+			this._log(LogLevel.Critical, this.format([message, ...args]));
 		}
 	}
 
@@ -163,4 +162,4 @@ export class SpdLogService extends AbstractLogService implements ILogService {
 
 		return result;
 	}
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -86,47 +86,46 @@ export class SpdLogService extends AbstractLogService implements ILogService {`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`- trace(): void {`
	`89`	`+ trace(message: string, ...args: any[]): void {`
`90`	`90`	`if (this.getLevel() <= LogLevel.Trace) {`
`91`		`- this._log(LogLevel.Trace, this.format(arguments));`
	`91`	`+ this._log(LogLevel.Trace, this.format([message, ...args]));`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`- debug(): void {`
	`95`	`+ debug(message: string, ...args: any[]): void {`
`96`	`96`	`if (this.getLevel() <= LogLevel.Debug) {`
`97`		`- this._log(LogLevel.Debug, this.format(arguments));`
	`97`	`+ this._log(LogLevel.Debug, this.format([message, ...args]));`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
`101`		`- info(): void {`
	`101`	`+ info(message: string, ...args: any[]): void {`
`102`	`102`	`if (this.getLevel() <= LogLevel.Info) {`
`103`		`- this._log(LogLevel.Info, this.format(arguments));`
	`103`	`+ this._log(LogLevel.Info, this.format([message, ...args]));`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
`107`		`- warn(): void {`
	`107`	`+ warn(message: string, ...args: any[]): void {`
`108`	`108`	`if (this.getLevel() <= LogLevel.Warning) {`
`109`		`- this._log(LogLevel.Warning, this.format(arguments));`
	`109`	`+ this._log(LogLevel.Warning, this.format([message, ...args]));`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`
`113`		`- error(): void {`
	`113`	`+ error(message: string \| Error, ...args: any[]): void {`
`114`	`114`	`if (this.getLevel() <= LogLevel.Error) {`
`115`		`- const arg = arguments[0];`
`116`	`115`
`117`		`- if (arg instanceof Error) {`
	`116`	`+ if (message instanceof Error) {`
`118`	`117`	`const array = Array.prototype.slice.call(arguments) as any[];`
`119`		`- array[0] = arg.stack;`
	`118`	`+ array[0] = message.stack;`
`120`	`119`	`this._log(LogLevel.Error, this.format(array));`
`121`	`120`	`} else {`
`122`		`- this._log(LogLevel.Error, this.format(arguments));`
	`121`	`+ this._log(LogLevel.Error, this.format([message, ...args]));`
`123`	`122`	`}`
`124`	`123`	`}`
`125`	`124`	`}`
`126`	`125`
`127`		`- critical(): void {`
	`126`	`+ critical(message: string \| Error, ...args: any[]): void {`
`128`	`127`	`if (this.getLevel() <= LogLevel.Critical) {`
`129`		`- this._log(LogLevel.Critical, this.format(arguments));`
	`128`	`+ this._log(LogLevel.Critical, this.format([message, ...args]));`
`130`	`129`	`}`
`131`	`130`	`}`
`132`	`131`
`@@ -163,4 +162,4 @@ export class SpdLogService extends AbstractLogService implements ILogService {`
`163`	`162`
`164`	`163`	`return result;`
`165`	`164`	`}`
`166`		`-}`
	`165`	`+}`