Make sure webviews are properly destroyed/hidden when the webview editor is hidden by a maximized panel

mjbvz · mjbvz · commit 4eec0cf21ecf · 2020-04-14T15:32:44.000-07:00
Fixes microsoft#94805
diff --git a/src/vs/workbench/contrib/webview/browser/webviewEditor.ts b/src/vs/workbench/contrib/webview/browser/webviewEditor.ts
@@ -86,11 +86,10 @@ export class WebviewEditor extends BaseEditor {
 	protected setEditorVisible(visible: boolean, group: IEditorGroup | undefined): void {
 		if (this.input instanceof WebviewInput && this.webview) {
 			if (visible) {
-				this.webview.claim(this);
+				this.claimWebview(this.input);
 			} else {
 				this.webview.release(this);
 			}
-			this.claimWebview(this.input);
 		}
 		super.setEditorVisible(visible, group);
 	}

Original file line number	Diff line number	Diff line change
`@@ -86,11 +86,10 @@ export class WebviewEditor extends BaseEditor {`
`86`	`86`	`protected setEditorVisible(visible: boolean, group: IEditorGroup \| undefined): void {`
`87`	`87`	`if (this.input instanceof WebviewInput && this.webview) {`
`88`	`88`	`if (visible) {`
`89`		`- this.webview.claim(this);`
	`89`	`+ this.claimWebview(this.input);`
`90`	`90`	`} else {`
`91`	`91`	`this.webview.release(this);`
`92`	`92`	`}`
`93`		`- this.claimWebview(this.input);`
`94`	`93`	`}`
`95`	`94`	`super.setEditorVisible(visible, group);`
`96`	`95`	`}`