Screen reader does not announce the expand state of select box

isidorn · isidorn · commit 4ea4be72675c · 2020-06-09T12:13:32.000+02:00
fixes microsoft#76869
diff --git a/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts b/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
@@ -464,6 +464,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
 		// Track initial selection the case user escape, blur
 		this._currentSelection = this.selected;
 		this._isVisible = true;
+		this.selectElement.setAttribute('aria-expanded', 'true');
 	}
 
 	private hideSelectDropDown(focusSelect: boolean) {
@@ -472,6 +473,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
 		}
 
 		this._isVisible = false;
+		this.selectElement.setAttribute('aria-expanded', 'false');
 
 		if (focusSelect) {
 			this.selectElement.focus();

Original file line number	Diff line number	Diff line change
`@@ -464,6 +464,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi`
`464`	`464`	`// Track initial selection the case user escape, blur`
`465`	`465`	`this._currentSelection = this.selected;`
`466`	`466`	`this._isVisible = true;`
	`467`	`+ this.selectElement.setAttribute('aria-expanded', 'true');`
`467`	`468`	`}`
`468`	`469`
`469`	`470`	`private hideSelectDropDown(focusSelect: boolean) {`
`@@ -472,6 +473,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi`
`472`	`473`	`}`
`473`	`474`
`474`	`475`	`this._isVisible = false;`
	`476`	`+ this.selectElement.setAttribute('aria-expanded', 'false');`
`475`	`477`
`476`	`478`	`if (focusSelect) {`
`477`	`479`	`this.selectElement.focus();`