Fixes buggy onEnter behavior when used with generator method (microsoft#100076)

lambainsaan · web-flow · commit 4dfc14b846a0 · 2020-06-15T11:57:40.000-07:00
* Adds regex to ignore already closed comment block

* Adds test case for generator method onEnter buggy behavior
diff --git a/extensions/typescript-language-features/src/features/languageConfiguration.ts b/extensions/typescript-language-features/src/features/languageConfiguration.ts
@@ -31,7 +31,7 @@ const jsTsLanguageConfiguration: vscode.LanguageConfiguration = {
 		}, {
 			// e.g.  * ...|
 			beforeText: /^(\t|[ ])*[ ]\*([ ]([^\*]|\*(?!\/))*)?$/,
-			oneLineAboveText: /^(\s*(\/\*\*|\*)).*/,
+			oneLineAboveText: /(?=^(\s*(\/\*\*|\*)).*)(?=(?!(\s*\*\/)))/,
 			action: { indentAction: vscode.IndentAction.None, appendText: '* ' },
 		}, {
 			// e.g.  */|
diff --git a/src/vs/editor/test/common/modes/supports/javascriptOnEnterRules.ts b/src/vs/editor/test/common/modes/supports/javascriptOnEnterRules.ts
@@ -18,7 +18,7 @@ export const javascriptOnEnterRules = [
 	}, {
 		// e.g.  * ...|
 		beforeText: /^(\t|[ ])*[ ]\*([ ]([^\*]|\*(?!\/))*)?$/,
-		oneLineAboveText: /^(\s*(\/\*\*|\*)).*/,
+		oneLineAboveText: /(?=^(\s*(\/\*\*|\*)).*)(?=(?!(\s*\*\/)))/,
 		action: { indentAction: IndentAction.None, appendText: '* ' }
 	}, {
 		// e.g.  */|
diff --git a/src/vs/editor/test/common/modes/supports/onEnter.test.ts b/src/vs/editor/test/common/modes/supports/onEnter.test.ts
@@ -118,6 +118,7 @@ suite('OnEnter', () => {
 		testIndentAction(' *', ' * asdfsfagadfg * / * / * /*', '', IndentAction.None, '* ');
 
 		testIndentAction('', ' */', '', IndentAction.None, null, 1);
+		testIndentAction(' */', ' * test() {', '', IndentAction.Indent, null, 0);
 		testIndentAction('', '\t */', '', IndentAction.None, null, 1);
 		testIndentAction('', '\t\t */', '', IndentAction.None, null, 1);
 		testIndentAction('', '   */', '', IndentAction.None, null, 1);
